New issue
Advanced search Search tips

Issue 671805 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 670843
issue 674313

Blocking:
issue 601332
issue 671802
issue 675023



Sign in to add a comment

Change run-webkit-tests default test order to random

Project Member Reported by jeffcarp@chromium.org, Dec 6 2016

Issue description

This change should be tested and land on December 14.

Full RandomOrder context here:
https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit
 
Cc: qyears...@chromium.org
Labels: -Pri-3 Pri-1
Summary: Change run-webkit-tests default test order to random (was: Change run_layout_tests default test order to random)
Blockedon: 674313
Blocking: 671802
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf4cbd7b38be23f7bcf3aab5ed3a448f5bc6dd5d

commit cf4cbd7b38be23f7bcf3aab5ed3a448f5bc6dd5d
Author: jeffcarp <jeffcarp@chromium.org>
Date: Fri Dec 16 22:11:28 2016

Change run_webkit_tests default order to random on Linux and Mac

This is the first step in moving all platforms to random order. Once Windows is stable in random order I will follow this up with a CL that removes the platform-specific logic and leaves default='random' for --order.

BUG= 671805 
R=dpranke@chromium.org,qyearsley@chromium.org,ojan@chromium.org

Review-Url: https://codereview.chromium.org/2557673003
Cr-Commit-Position: refs/heads/master@{#439210}

[modify] https://crrev.com/cf4cbd7b38be23f7bcf3aab5ed3a448f5bc6dd5d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/cf4cbd7b38be23f7bcf3aab5ed3a448f5bc6dd5d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Blockedon: 670843
Linux & Mac have been successfully moved to random order. Working on Windows this week.
Blocking: 675023
I plan on landing https://codereview.chromium.org/2591933002 tomorrow (Wednesday) morning to move all other builds over to random.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c51ad71bc112439aedbc8c8e1906f9ea098da9cc

commit c51ad71bc112439aedbc8c8e1906f9ea098da9cc
Author: jeffcarp <jeffcarp@chromium.org>
Date: Wed Jan 04 21:14:01 2017

Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ )

Reason for revert:
fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.

Original issue's description:
> Make run_webkit_tests random order by default for all platforms.
>
> BUG= 671805 
> R=dpranke@chromium.org,qyearsley@chromium.org
>
> Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
> Cr-Commit-Position: refs/heads/master@{#441424}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671805 

Review-Url: https://codereview.chromium.org/2617563002
Cr-Commit-Position: refs/heads/master@{#441465}

[modify] https://crrev.com/c51ad71bc112439aedbc8c8e1906f9ea098da9cc/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/c51ad71bc112439aedbc8c8e1906f9ea098da9cc/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8e75174463273c99caae55d988ebcf935582f5c

commit f8e75174463273c99caae55d988ebcf935582f5c
Author: jeffcarp <jeffcarp@chromium.org>
Date: Fri Jan 06 03:13:20 2017

Reland of Make run_webkit_tests random order by default for all platforms (patchset #1 id:1 of https://codereview.chromium.org/2617563002/ )

Reason for revert:
Re-land

Original issue's description:
> Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ )
>
> Reason for revert:
> fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.
>
> Original issue's description:
> > Make run_webkit_tests random order by default for all platforms.
> >
> > BUG= 671805 
> > R=dpranke@chromium.org,qyearsley@chromium.org
> >
> > Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
> > Cr-Commit-Position: refs/heads/master@{#441424}
>
> TBR=dpranke@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 671805 
>
> Committed: https://crrev.com/c51ad71bc112439aedbc8c8e1906f9ea098da9cc
> Cr-Commit-Position: refs/heads/master@{#441465}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671805 

Review-Url: https://codereview.chromium.org/2612083003
Cr-Commit-Position: refs/heads/master@{#441859}

[modify] https://crrev.com/f8e75174463273c99caae55d988ebcf935582f5c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/f8e75174463273c99caae55d988ebcf935582f5c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Status: Fixed (was: Assigned)
All platforms are now random order by default!

Sign in to add a comment