New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671797 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit 21 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

CCT/Herb menu items update

Project Member Reported by sbirch@chromium.org, Dec 6 2016

Issue description

Per UI review [1], diff is:
- Add bookmark action & download action to the top bar
- Add "Add to home screen" and "Request desktop site" to the menu
- The return of "find in page"!

Internal notes: https://docs.google.com/document/d/1SqkUS81JKfNuZxiOzYKJNmPRkujwKYKy1WcHBRI77fw/edit#heading=h.6xrmgwy3tyrx


 

Comment 1 by rolfe@chromium.org, Dec 7 2016

Cc: rolfe@chromium.org
Owner: sbirch@chromium.org
UI review thread:
https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/tEIF6tvoxxU

Menu mocks
https://folio.googleplex.com/chrome-ux/mocks/293-web-view-read-only-mode/120516_Menus#%2F02_AddAllPageActions.png

Bookmarks flow
https://folio.googleplex.com/chrome-ux/mocks/293-web-view-read-only-mode/120516_Menus#%2F03_BookmarksInCCT.png

Downloads flow
https://folio.googleplex.com/chrome-ux/mocks/293-web-view-read-only-mode/120516_Menus#%2F04_DownloadsInCCT.png

Changes:
1) Add "Find in page," RDS, A2HS (persistently), Bookmark and Download
2) Append "in Chrome" to "Downloaded" and "Bookmarked" snackbars

I don't think you need anything else from UX but let me know if otherwise. Reassigning ownership to sbirch@ for triage.

Comment 2 by yus...@chromium.org, Dec 12 2016

Cc: ian...@chromium.org
ianwen@ had mentioned, he might have cycles to handle this. sbirch@ if this one is good to go, feel free to assign it to him with a milestone.

Comment 3 by talo@chromium.org, Dec 15 2016

Cc: dewittj@chromium.org
Just to throw one more consideration in here that dewittj brought up, it would be great to be able to differentiate in UMA whether the downloaded page was taken from CCT or from a regular Chrome tab just to measure the impact of the change. 

Sam, is this something we'd want for all of the actions? We're happy to help with this for download action!

Comment 4 by yus...@chromium.org, Dec 15 2016

Cc: ltian@chromium.org

Comment 5 by sbirch@chromium.org, Dec 15 2016

It should be possible with sequence analysis automatically since we log when a CCT is opened/closed. If you prefer, adding an explicit split sounds fine to me too. Bonus points if there's a way to do it for all the menu items consistently :).

Comment 6 by sbirch@chromium.org, Dec 20 2016

One addition: we should also update the "Download link" option in the context menu to have the same snackbar behavior. And probably append "in Chrome" to the text.

Comment 7 by yus...@chromium.org, Dec 21 2016

sbirch@, should #6 be a part of Issue 565505 rather than this, since that will handle context menu changes?
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5abc9695b5db94035f872aaaea6c833e70971e2d

commit 5abc9695b5db94035f872aaaea6c833e70971e2d
Author: ltian <ltian@chromium.org>
Date: Thu Jan 05 20:43:05 2017

[Android]Update CCT/Herb menu item

Add more items to CCT/Herb menu including:
1. Bookmark action & Download action to the top bar
2. "Add to home screen" and "Request desktop site" to the menu
3. The return of "find in page"

Udpate text message in the snackbar for Bookmark action and Download
action to display which app the action is execucted. For example, if CCT
is opened in Chrome Dev, the text in the snackbar for Bookmark should be
"Bookmarked in Chrome Dev".

BUG= 671797 

Review-Url: https://codereview.chromium.org/2596973002
Cr-Commit-Position: refs/heads/master@{#441743}

[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/res/menu/custom_tabs_menu.xml
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/5abc9695b5db94035f872aaaea6c833e70971e2d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Comment 9 by ltian@chromium.org, Jan 5 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 6 2017

Woohoo! To Tal's request in #3, it would be easier to see these actions in sequence if we had a user action for the CCT menu being opened initially. "CustomTabsMenuOpened" perhaps?
Status: Verified (was: Fixed)
Verified on 57.0.2977.0. Thank you!

Still pending Sam's query in comment#11.

Sign in to add a comment