New issue
Advanced search Search tips

Issue 671786 link

Starred by 1 user
Status: Fixed
Owner:
kenrb@chromium.org
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove check for null Document in RenderFrameImpl::OnMessageReceived

Project Member Reported by kenrb@chromium.org, Dec 6 2016 
RenderFrameImpl::OnMessageReceived() contains a check for Document.isNull() that is obsolete. RenderFrameProxy no longer wraps RenderFrameImpl, so the Document should never be null.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6241c26f033f7c7e691c76f4c885c96387e81932

commit 6241c26f033f7c7e691c76f4c885c96387e81932
Author: kenrb <kenrb@chromium.org>
Date: Thu Dec 08 18:11:55 2016

Remove null Document check from RenderFrameImpl::OnMessageReceived

This check is obsolete, there should no longer be any case where the
Document is null at this point.

BUG= 671786 

Review-Url: https://codereview.chromium.org/2561453002
Cr-Commit-Position: refs/heads/master@{#437284}

[modify] https://crrev.com/6241c26f033f7c7e691c76f4c885c96387e81932/content/renderer/render_frame_impl.cc

Comment 2 by kenrb@chromium.org, Dec 9 2016

Status: Fixed (was: Started)
►

Sign in to add a comment