Issue metadata
Sign in to add a comment
|
Panel jump menus broken |
||||||||||||||||||||||
Issue description- search+ctrl+l - enter (over a menu item) result: focus doesn't land predictably expected: focus actually goes to the item selected.
,
Dec 6 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f commit f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f Author: dtseng <dtseng@chromium.org> Date: Wed Dec 07 18:20:21 2016 Fix broken panel menus Regressed by https://codereview.chromium.org/2443103004 The code missed the fact that |node| changes value outside of the Closure and so doesn't actually refer to the expected node (i.e. |node| is always the last node in the AX tree). TEST=use the menus; press enter over an item and make sure things actually work. BUG= 671778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2556893002 Cr-Commit-Position: refs/heads/master@{#437009} [modify] https://crrev.com/f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
,
Dec 7 2016
,
Dec 8 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 12 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d327e75089cac3ab510b434b763d81f67f0b74e commit 9d327e75089cac3ab510b434b763d81f67f0b74e Author: David Tseng <dtseng@chromium.org> Date: Mon Dec 12 18:54:17 2016 Merge to m56: Fix broken panel menus Regressed by https://codereview.chromium.org/2443103004 The code missed the fact that |node| changes value outside of the Closure and so doesn't actually refer to the expected node (i.e. |node| is always the last node in the AX tree). TEST=use the menus; press enter over an item and make sure things actually work. BUG= 671778 TBR=dtseng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2556893002 Cr-Commit-Position: refs/heads/master@{#437009} (cherry picked from commit f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f) Review-Url: https://codereview.chromium.org/2568913002 . Cr-Commit-Position: refs/branch-heads/2924@{#463} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/9d327e75089cac3ab510b434b763d81f67f0b74e/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
,
Dec 12 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Dec 6 2016