New issue
Advanced search Search tips

Issue 671778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: 2016-12-12
OS: ----
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Panel jump menus broken

Project Member Reported by dtseng@chromium.org, Dec 6 2016

Issue description

- search+ctrl+l
- enter (over a menu item)

result:
focus doesn't land predictably

expected:
focus actually goes to the item selected.

 
Labels: M-56
Labels: -Pri-3 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f

commit f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f
Author: dtseng <dtseng@chromium.org>
Date: Wed Dec 07 18:20:21 2016

Fix broken panel menus

Regressed by
https://codereview.chromium.org/2443103004

The code missed the fact that |node| changes value outside of the Closure and so doesn't actually refer to the expected node (i.e. |node| is always the last node in the AX tree).

TEST=use the menus; press enter over an item and make sure things actually work.
BUG= 671778 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2556893002
Cr-Commit-Position: refs/heads/master@{#437009}

[modify] https://crrev.com/f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js

Labels: Merge-Request-56

Comment 5 by dimu@chromium.org, Dec 8 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 12 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d327e75089cac3ab510b434b763d81f67f0b74e

commit 9d327e75089cac3ab510b434b763d81f67f0b74e
Author: David Tseng <dtseng@chromium.org>
Date: Mon Dec 12 18:54:17 2016

Merge to m56: Fix broken panel menus

Regressed by
https://codereview.chromium.org/2443103004

The code missed the fact that |node| changes value outside of the Closure and so doesn't actually refer to the expected node (i.e. |node| is always the last node in the AX tree).

TEST=use the menus; press enter over an item and make sure things actually work.
BUG= 671778 
TBR=dtseng@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2556893002
Cr-Commit-Position: refs/heads/master@{#437009}
(cherry picked from commit f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f)

Review-Url: https://codereview.chromium.org/2568913002 .
Cr-Commit-Position: refs/branch-heads/2924@{#463}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/9d327e75089cac3ab510b434b763d81f67f0b74e/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js

Comment 8 by dtseng@chromium.org, Dec 12 2016

NextAction: 2016-12-12
Status: fixed (was: Assigned)

Sign in to add a comment