New issue
Advanced search Search tips

Issue 671751 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
hinoka@chromium.org
vapier@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

footer should include a link to the source

Project Member Reported by vapier@chromium.org, Dec 6 2016 
if i visit a luci page and i'd like to make an improvement, i have to figure out where the source lives.  it'd be great if the footer contained a direct link to the relevant repo (and perhaps even the relevant sub-file).

for example, this page:
https://luci-milo.appspot.com/

has at the bottom:
luci, working for the Chromium project.
Page built: Tue, 2016-12-06 2:59:16 PM (All times local)

i'm guessing we have our own fork of github.com/luci somewhere, so the github page won't work for us

Comment 1 by estaab@chromium.org, Dec 10 2016

Status: Available (was: Untriaged)
Good idea, we'll have to think of a way to present this in a reusable way with our other luci services.

By the way, we own github.com/luci and that's the source of truth and the right code to modify.
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by efoo@chromium.org, Dec 11 2017

Cc: vapier@chromium.org
Status: WontFix (was: Untriaged)
CC'ing vapier@chromium.org

Have you taken a look at the new ci.chromium.org pages? Does the current UX satisfy your initial request? Please take a look and re-open this bug to "Untriaged" with further details.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e

commit 87a2baef2c8f0a97ee769219cdc9b175bf2aca3e
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Dec 12 00:28:10 2017

[milo] fix link to source code

Bug:  671751 
Change-Id: If399f399b6a52133b6651fece24b324e08361f3a
Reviewed-on: https://chromium-review.googlesource.com/820624
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>

[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/appengine/templates/includes/base.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.builder-Basic_Test_no_builds.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/console-Full_console_with_Header.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/frontpage-Basic_frontpage.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/search-Basic_search_page.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/87a2baef2c8f0a97ee769219cdc9b175bf2aca3e/milo/frontend/expectations/swarming.log-Basic_log.html

Comment 5 by no...@chromium.org, Dec 12 2017

Status: Fixed (was: WontFix)

Comment 6 by efoo@chromium.org, Dec 22 2017

Labels: LUCI-M3-S12 LUCI-M3-Beta

Comment 7 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 8 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-M3-Beta
►

Sign in to add a comment