New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671734 link

Starred by 1 user
Status: Assigned
Owner:
█ nasko@chromium.org
Out until 24 Jan
Cc:
rdevlin....@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 417518
issue 870761



Sign in to add a comment

WebNavigationApiTest.ServerRedirectSingleProcess from browser_tests fails with site-per-process

Project Member Reported by lukasza@chromium.org, Dec 6 2016 
Repro:
$ DISPLAY=:20 out/gn/browser_tests --site-per-process \
    --gtest_filter=*WebNavigationApiTest.ServerRedirectSingleProcess*

Expected: the test passes

Actual: the test fails

The first failure in the test output is:

[73442:73442:1206/113813.566535:INFO:CONSOLE(0)] "[FAIL] serverRedirectSingleProcess: Received unexpected event 'onCommi
tted':{"frameId":0,"processId":1,"tabId":0,"timeStamp":0,"transitionQualifiers":["server_redirect"],"transitionType":"ty
ped","url":"http://www.b.com:51782/test"}
Error
    at Object.<anonymous> (extensions::test:105:11)
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at captureEvent (chrome-extension://jnjjadmoajjnlbhmeanchokknbnkpkmc/_test_resources/api_test/webnavigation/framewor
k.js:194:17)
    at chrome-extension://jnjjadmoajjnlbhmeanchokknbnkpkmc/_test_resources/api_test/webnavigation/framework.js:211:5
    at EventImpl.dispatchToListener (extensions::event_bindings:388:22)
    at Event.publicClassPrototype.(anonymous function) [as dispatchToListener] (extensions::utils:149:26)
    at EventImpl.dispatch_ (extensions::event_bindings:372:35)
    at dispatchArgs (extensions::event_bindings:244:26)
    at dispatchEvent (extensions::event_bindings:253:7)", source: chrome-extension://jnjjadmoajjnlbhmeanchokknbnkpkmc/te
st_serverRedirectSingleProcess.html (0)

Comment 1 by lukasza@chromium.org, Dec 6 2016

Cc: rdevlin....@chromium.org
Owner: nasko@chromium.org
Status: Assigned (was: Untriaged)
Assigning to nasko@ for now, since AFAIK he has recently worked on similar test problems for PlzNavigate.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0950ec373d3f263d2d4cad3c258f3c7eb8c545a3

commit 0950ec373d3f263d2d4cad3c258f3c7eb8c545a3
Author: lukasza <lukasza@chromium.org>
Date: Tue Dec 06 21:04:52 2016

Refer to more specific bugs in --site-per-process browser_tests filters.

BUG=671712, 671734

Review-Url: https://codereview.chromium.org/2555863002
Cr-Commit-Position: refs/heads/master@{#436720}

[modify] https://crrev.com/0950ec373d3f263d2d4cad3c258f3c7eb8c545a3/testing/buildbot/filters/site-per-process.browser_tests.filter
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1c039e493c3a2bbde717f71273a9fba792ab498

commit c1c039e493c3a2bbde717f71273a9fba792ab498
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Mar 27 16:26:47 2018

Inline site-per-process expectations for //chrome-layer tests.

We plan to make --site-per-process mode the default mode on ToT for
//chrome layer.  To make this switch slightly easier, this CL inlines
the test expectations from //testing/buildbot/filters into the source
code of the tests - this should avoid having to keep passing the filter
files to the default test steps after making the switch.

Bug: 671734, 824962,  824966 
Change-Id: I4ce397f5a7be18cc184f081058bf57f2e7c6239f
Reviewed-on: https://chromium-review.googlesource.com/976643
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546128}
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/chrome/test/BUILD.gn
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/PRESUBMIT.py
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/filters/BUILD.gn
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/filters/README.md
[delete] https://crrev.com/36cb2980b99b9302adf4e681511431b17f335693/testing/buildbot/filters/site-per-process.browser_tests.filter
[delete] https://crrev.com/36cb2980b99b9302adf4e681511431b17f335693/testing/buildbot/filters/site-per-process.interactive_ui_tests.filter
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/test_suites.pyl

Comment 4 by lukasza@chromium.org, Aug 3

Blocking: 870761
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5108e8611f81322fba060a2b3e30a17b8e2476df

commit 5108e8611f81322fba060a2b3e30a17b8e2476df
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Aug 06 22:08:51 2018

Adjust ServerRedirectSingleProcess expectations for site-per-process.

WebNavigationApiTest.ServerRedirectSingleProcess from browser_tests has
its expectations in
serverRedirectSingleProcess/test_serverRedirectSingleProcess.js.  The
expectations include exact |processId| ("exact" meaning that one cannot
use a wildcard - the verification is done via chrome.test.checkDeepEq).
Inclusion of |processId| means that the expectation change in
site-per-process mode.

This CL flips the expectations to match the expected behavior in
site-per-process mode and disables the test outside of site-per-process
mode.  The "disabling" can be removed in a follow-up CL, after we only
run //chrome-layer tests in site-per-process mode.

Bug: 671734
Change-Id: I984d67342008c3025b84406d99d4798ca46d77f6
Reviewed-on: https://chromium-review.googlesource.com/1162909
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581003}
[modify] https://crrev.com/5108e8611f81322fba060a2b3e30a17b8e2476df/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/5108e8611f81322fba060a2b3e30a17b8e2476df/chrome/test/data/extensions/api_test/webnavigation/serverRedirectSingleProcess/test_serverRedirectSingleProcess.js

Comment 6 by lukasza@chromium.org, Aug 6 

This test now passes when run with --site-per-process (so it does no longer block issue 870761).  OTOH, in CR for the CL from #c5 nasko@ said that the test seems to have drifted away from what it was initially testing and that he can take a look at the history of the test and adjust it if needed.  Therefore, I am leaving this bug opened and assigned to nasko@ for now.
►

Sign in to add a comment