New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671731 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

CSS feature usage using unstable property ID instead of stable histogram ID

Project Member Reported by pmeenan@chromium.org, Dec 6 2016

Issue description

The blink.feature_usage trace events for CSS features are using the unstable property ID instead of the stable ID that is used for histograms.  The trace events should be switched to use the same stable ID's as UMA.

See: https://github.com/HTTPArchive/httparchive/issues/59#issuecomment-265229420
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f983fdfad8789c3c70e818d2cb452cd497ac407

commit 9f983fdfad8789c3c70e818d2cb452cd497ac407
Author: pmeenan <pmeenan@chromium.org>
Date: Tue Dec 06 22:44:42 2016

Switched feature usage trace events to use the stable feature ID's

The trace events for CSS feature usage were using the unstable property
ID which doesn't match what is reported in UMA.  This change switches
the trace events to use the same stable feature ID that is reported to
UMA.

BUG= 671731 

Review-Url: https://codereview.chromium.org/2558583002
Cr-Commit-Position: refs/heads/master@{#436762}

[modify] https://crrev.com/9f983fdfad8789c3c70e818d2cb452cd497ac407/third_party/WebKit/Source/core/frame/UseCounter.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/941bbccd519d77ed2a7ce32be3860e6fc091dccd

commit 941bbccd519d77ed2a7ce32be3860e6fc091dccd
Author: pmeenan <pmeenan@chromium.org>
Date: Wed Dec 07 20:05:19 2016

Changed the css feature name trace string to avoid collisions

We recently changed the feature-usage trace events to use the stable CSS
property ID.  This changes the label for the trace events so tools can
deterministically know that they are getting the new, stable property
ID's.

BUG= 671731 

Review-Url: https://codereview.chromium.org/2556103002
Cr-Commit-Position: refs/heads/master@{#437042}

[modify] https://crrev.com/941bbccd519d77ed2a7ce32be3860e6fc091dccd/third_party/WebKit/Source/core/frame/UseCounter.cpp

Status: Fixed (was: Started)

Comment 4 by rbyers@chromium.org, Jan 31 2017

Labels: M-57

Sign in to add a comment