New issue
Advanced search Search tips

Issue 671730 link

Starred by 1 user
Status: Fixed
Owner:
ksakamoto@chromium.org
Closed: Dec 2016
Cc:
kouhei@chromium.org
benjhayden@chromium.org
nedngu...@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

System health loading metrics failing on android webview

Project Member Reported by rnep...@chromium.org, Dec 6 2016 
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_WebView_Perf__2_%2F3027%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.common_mobile%2F0%2Fstdout

https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf%20%282%29/builds/3027

[ RUN      ] /tmp/tmppeS9bC.html
MapFunctionError: Cannot read property 'sliceGroup' of undefined
    at Object.NavigationStartFinder (/tracing/metrics/system_health/loading_metric.html:55:45)
    at collectLoadingMetricsForRenderer (/tracing/metrics/system_health/loading_metric.html:360:33)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:406:11)
    at runMetrics (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:69:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)
[  FAILED  ] /tmp/tmppeS9bC.html (2566 ms)
Traceback (most recent call last):
  File "/b/rr/tmpo2MyTB/w/src/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: MapFunctionError: Cannot read property 'sliceGroup' of undefined
    at Object.NavigationStartFinder (/tracing/metrics/system_health/loading_metric.html:55:45)
    at collectLoadingMetricsForRenderer (/tracing/metrics/system_health/loading_metric.html:360:33)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:406:11)
    at runMetrics (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:69:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/rr/tmpo2MyTB/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)

[  FAILED  ] background:tools:gmail (39680 ms)


Highly suspect:

Change #35717

Changed by	nednguyen@google.com
Changed at	Wed 30 Nov 2016 18:11:08
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	ba3f0989e24c659d2b204918b40c0ece13cc2335
Comments

[tools/perf] Enable loading metrics for common system health benchmarks

BUG= chromium:669526 

Review-Url: https://codereview.chromium.org/2534243002
Cr-Commit-Position: refs/heads/master@{#435527}
Changed files

tools/perf/benchmarks/loading.py
tools/perf/benchmarks/page_cycler_v2.py
tools/perf/benchmarks/system_health.py

Comment 1 by rnep...@chromium.org, Dec 6 2016 

Also failing in the same way here on the nexus 6 webview bot:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%281%29/builds/1320

Comment 2 by nedngu...@google.com, Dec 6 2016

Cc: nedngu...@google.com kouhei@chromium.org
Owner: ksakamoto@chromium.org
Status: Assigned (was: Untriaged)
Ksakamoto: can you take a look?

Comment 4 by ksakamoto@chromium.org, Dec 7 2016

Cc: benjhayden@chromium.org
This is https://github.com/catapult-project/catapult/issues/1802.
Since there is no renderer process in webview, ChromeRendererHelper.mainThread returns undefined.

https://crrev.com/2558743002/ will fix the issue in loading metric, but I'm not sure if this is the right fix.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4716219b58d4069fc6686d3217d98278ad62ec7e

commit 4716219b58d4069fc6686d3217d98278ad62ec7e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Dec 09 06:26:02 2016

Roll src/third_party/catapult/ 0b7222ff3..df2363501 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0b7222ff3002..df2363501bd7

$ git log 0b7222ff3..df2363501 --date=short --no-merges --format='%ad %ae %s'
2016-12-08 ksakamoto ChromeRendererHelper treats Chrome_InProcRendererThread as main thread
2016-12-08 benjhayden Reland Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

BUG= 671730 , 651188 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2568433002
Cr-Commit-Position: refs/heads/master@{#437484}

[modify] https://crrev.com/4716219b58d4069fc6686d3217d98278ad62ec7e/DEPS

Comment 6 by ksakamoto@chromium.org, Dec 12 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment