Rename kWindowIgnoredByShelf_Property to kWindowIgnoredByShelf_InitProperty and don't look for changes |
||||||
Issue descriptionWe need an aura::client property for this that makes to kWindowIgnoredByShelf_Property. Doing this means we can consolidate logic in WmWindowAura.
,
Feb 28 2017
Turns out we only need to change this property during window construction. So, we should instead rename the property to kWindowIgnoredByShelf_InitProperty and simplify code.
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/003bccb313db261e4439ebf2adb8f5dcb13710a9 commit 003bccb313db261e4439ebf2adb8f5dcb13710a9 Author: sky <sky@chromium.org> Date: Wed Mar 01 04:48:35 2017 Renames kWindowIgnoredByShelf_Property to ..._InitProperty We only need to set this during initial window creation, so set rename the property appropriately and update code as appropiate. BUG= 671729 TEST=none R=jamescook@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2715243012 Cr-Commit-Position: refs/heads/master@{#453843} [modify] https://crrev.com/003bccb313db261e4439ebf2adb8f5dcb13710a9/ash/mus/top_level_window_factory.cc [modify] https://crrev.com/003bccb313db261e4439ebf2adb8f5dcb13710a9/ash/mus/window_manager.cc [modify] https://crrev.com/003bccb313db261e4439ebf2adb8f5dcb13710a9/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/003bccb313db261e4439ebf2adb8f5dcb13710a9/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/003bccb313db261e4439ebf2adb8f5dcb13710a9/services/ui/public/interfaces/window_manager.mojom
,
Mar 6 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sky@chromium.org
, Dec 12 2016