Animation is janky when opening the incognito NTP from tab switcher |
||||||
Issue descriptionApp Version: 57.0.2943.0 canary iOS Version: 9.3.5, 10.2 Device: iPhone7, iPad Air2 URL: na Steps to reproduce: 1. Launch Google Chrome 2. Close all Incognito tabs 3. Go to tab switcher mode 4. Click on + to open new tab Observed results: The Animation is janky when opening the incognito NTP from tab switcher Expected results: Incognito NTP page should open smoothly. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M55 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M56 Yes Type-bug-regression? No Link to video/image: https://drive.google.com/open?id=0B-tbaGTQZtpQblZOZl9yWHJsRXM
,
Dec 20 2016
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50d5ba259ac6c76e63884412fb1a214858b81654 commit 50d5ba259ac6c76e63884412fb1a214858b81654 Author: jif <jif@chromium.org> Date: Tue Dec 20 14:00:28 2016 Initialize the BrowserContainerView with the right frame. When the iPad Tab Switcher creates an incognito tab for the first time, an incognito BVC is created. The Tab Switcher takes a screenshot of the new incognito tab, and animates its size from a small cell to a fullscreen tab. Before this CL, the first incognito tab was created with an incorrect size, resulting in the screenshot used in the animation being incorrect. BUG= 671724 Review-Url: https://codereview.chromium.org/2591683002 Cr-Commit-Position: refs/heads/master@{#439792} [modify] https://crrev.com/50d5ba259ac6c76e63884412fb1a214858b81654/ios/chrome/browser/ui/browser_view_controller.mm
,
Feb 1 2017
,
Feb 1 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 1 2017
Fixed landed before branch, so there should be nothing to cherry pick.
,
Feb 27 2017
New Incognito Tab animation looks good. Verified on iPad Pro Build: M57.0.2987.75 beta iOS: 10.1.1 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by justincohen@chromium.org
, Dec 7 2016Owner: jif@chromium.org
Status: Assigned (was: Untriaged)