New issue
Advanced search Search tips

Issue 671720 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

omnibox shouldn't offer file: suggestions on platforms that don't support them

Project Member Reported by srikanthg@chromium.org, Dec 6 2016

Issue description

App Version: 57.0.2943.0 canary
iOS Version: 9.3.5, 10.2
Device: iPad Air, iPhone7
URL: na

Steps to reproduce:
  1. Launch Google Chrome
  2. Tap on omnibox and search for "/n" (no quotes, forward slash and n)

Observed results: "Your file was not found" error page displayed

Expected results: Search results page should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO
Bug reproducible on current stable build (App Version, iOS Version): M55 Yes
Bug reproducible on the current beta channel build (App Version, iOS Version): M56 Yes

Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuTW5WRFFuSGNaUjg/view 
 
Cc: justincohen@chromium.org
Labels: ReleaseBlock-Stable M-57
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)
Cc: pkasting@chromium.org mpear...@chromium.org
Components: UI>Browser>Omnibox
Labels: -Restrict-View-Google -Pri-2 -ReleaseBlock-Stable -M-57 Pri-3
I see this on desktop as well, so we're presumably getting this behavior from the omnibox code.

@mpearson @pkasting does it seem reasonable to disable file navigations on OSes that don't have a user-visible filesystem? I don't think file:// urls will ever work on iOS.
Summary: omnibox shouldn't offer file: suggestions on platforms that don't support them (was: File not found error page displayed when a search query in omnibox starts with a forward slash)
> does it seem reasonable to disable file navigations on OSes that don't have a
> user-visible filesystem? I don't think file:// urls will ever work on iOS.

Yes.

Peter will know better whether the best idea is to force these types of inputs on these platforms to be queries (and hence we never would add what-you-typed URL match) or to revise HistoryURLProvider::SuggestExactInput() to just return an invalid URL if the destination URL not normally navigable on the platform in use.
One question is what should happen if the user actually enters "file:///something".  I suspect we should try to navigate, and fail, instead of forcing this to be a search on these platforms.  The answer to this question determines whether a change to the parsing code is needed.

Note that on Windows, /n does not navigate by default.  I think this is a POSIXism in the fixup code.  One possibility here is that we should #if that POSIXism to not be true on iOS.

We may also need to make a change to "not suggest a URL WYT match" in any file: case on iOS.

These three changes overlap but are all at least partly distinct.
Cc: mard...@chromium.org rohitrao@chromium.org
 Issue 322042  has been merged into this issue.
Labels: Hotlist-ios-fixit hotlist-ios-fixit-droger hotlist-ios-fixit-done
Cc: jdonnelly@chromium.org
Labels: Hotlist-Polish
Of the various parts in comment #4, I think the easiest and most accurate is to not suggest a file:// URL-what-you-type match on a platform that doesn't support them (iOS, maybe others) unless the input explicitly includes the scheme.  I believe this means the change can be scoped to history_url_provider.cc.

Owner: stkhapugin@chromium.org

Sign in to add a comment