omnibox shouldn't offer file: suggestions on platforms that don't support them |
|||||||
Issue descriptionApp Version: 57.0.2943.0 canary iOS Version: 9.3.5, 10.2 Device: iPad Air, iPhone7 URL: na Steps to reproduce: 1. Launch Google Chrome 2. Tap on omnibox and search for "/n" (no quotes, forward slash and n) Observed results: "Your file was not found" error page displayed Expected results: Search results page should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO Bug reproducible on current stable build (App Version, iOS Version): M55 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M56 Yes Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuTW5WRFFuSGNaUjg/view
,
Dec 7 2016
I see this on desktop as well, so we're presumably getting this behavior from the omnibox code. @mpearson @pkasting does it seem reasonable to disable file navigations on OSes that don't have a user-visible filesystem? I don't think file:// urls will ever work on iOS.
,
Dec 7 2016
> does it seem reasonable to disable file navigations on OSes that don't have a > user-visible filesystem? I don't think file:// urls will ever work on iOS. Yes. Peter will know better whether the best idea is to force these types of inputs on these platforms to be queries (and hence we never would add what-you-typed URL match) or to revise HistoryURLProvider::SuggestExactInput() to just return an invalid URL if the destination URL not normally navigable on the platform in use.
,
Dec 7 2016
One question is what should happen if the user actually enters "file:///something". I suspect we should try to navigate, and fail, instead of forcing this to be a search on these platforms. The answer to this question determines whether a change to the parsing code is needed. Note that on Windows, /n does not navigate by default. I think this is a POSIXism in the fixup code. One possibility here is that we should #if that POSIXism to not be true on iOS. We may also need to make a change to "not suggest a URL WYT match" in any file: case on iOS. These three changes overlap but are all at least partly distinct.
,
Dec 8 2016
,
Dec 8 2016
,
Dec 9 2016
,
Jun 22 2017
Of the various parts in comment #4, I think the easiest and most accurate is to not suggest a file:// URL-what-you-type match on a platform that doesn't support them (iOS, maybe others) unless the input explicitly includes the scheme. I believe this means the change can be scoped to history_url_provider.cc.
,
Aug 6
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by justincohen@chromium.org
, Dec 7 2016Labels: ReleaseBlock-Stable M-57
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)