New issue
Advanced search Search tips

Issue 671718 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove the dimmer in the Ash shelf

Project Member Reported by tdander...@chromium.org, Dec 6 2016

Issue description

Remove the 'dimmer' in the Ash shelf (the highlighted effect that appears during mouse hover).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7bf1d6fe4d505410b560cefcee2312fc759b4f8

commit f7bf1d6fe4d505410b560cefcee2312fc759b4f8
Author: estade <estade@chromium.org>
Date: Fri Dec 09 20:25:40 2016

Remove Ash shelf dimmer.

BUG= 671718 

Review-Url: https://codereview.chromium.org/2550413004
Cr-Commit-Position: refs/heads/master@{#437621}

[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/BUILD.gn
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/app_list_button.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/overflow_button.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/shelf_view.h
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/shelf_widget.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/shelf_widget.h
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/common/shelf/wm_dimmer_view.h
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/resources/ash_resources.grd
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/resources/default_100_percent/common/shelf/shelf_dimming.png
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/resources/default_100_percent/common/shelf/status_icon_background_onblack_normal.png
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_onblack_normal.png
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/resources/default_200_percent/common/shelf/shelf_dimming.png
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/resources/default_200_percent/common/shelf/status_icon_background_onblack_normal.png
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_onblack_normal.png
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/shelf/dimmer_view.cc
[delete] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/ash/shelf/dimmer_view.h
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/f7bf1d6fe4d505410b560cefcee2312fc759b4f8/ash/wm/overview/window_selector_unittest.cc

Comment 2 by est...@chromium.org, Dec 19 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment