New issue
Advanced search Search tips

Issue 671714 link

Starred by 2 users
Status: Archived
Owner:
sky@chromium.org
Closed: Mar 2017
Cc:
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Wire up ui::mojom::WindowManager::kShadowStyle_Property or remove

Project Member Reported by sky@chromium.org, Dec 6 2016 
kShadowStyle_Property is currently unused. I suspect it should map to the Shadow type, but it currently doesn't. Either connect it, or remove it.

Comment 1 by sky@chromium.org, Mar 7 2017

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad53642b18c11cfcfd5424ef18a5ba40637ae635

commit ad53642b18c11cfcfd5424ef18a5ba40637ae635
Author: sky <sky@chromium.org>
Date: Tue Mar 07 21:47:24 2017

Removes WindowManager::kShadowStyle_Property

It's unused and I don't believe we need it.

BUG= 671714 
TEST=none
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2736773003
Cr-Commit-Position: refs/heads/master@{#455228}

[modify] https://crrev.com/ad53642b18c11cfcfd5424ef18a5ba40637ae635/services/ui/public/interfaces/window_manager.mojom

Comment 3 by sky@chromium.org, Mar 7 2017

Status: Fixed (was: Started)
Shadows are routed via kShadowElevation_Property, so kShadowStyle_Property isn't needed.

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment