New issue
Advanced search Search tips

Issue 671712 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

All 4 IsolatedAppTest tests time out with --site-per-process

Project Member Reported by lukasza@chromium.org, Dec 6 2016

Issue description

Repro:
$ DISPLAY=:20 out/gn/browser_tests --gtest_filter=*IsolatedAppTest.* --site-per-process

Expected: tests pass

Actual: all 4 tests time out:

 4 tests timed out:
    IsolatedAppTest.CookieIsolation (../../chrome/browser/extensions/isolated_app_browsertest.cc:204)
    CrossProcessClientRedirect (../../chrome/browser/extensions/isolated_app_browsertest.cc:141)
    IsolatedAppTest.IsolatedAppProcessModel (../../chrome/browser/extensions/isolated_app_browsertest.cc:455)
    IsolatedAppTest.SubresourceCookieIsolation (../../chrome/browser/extensions/isolated_app_browsertest.cc:379)
 
Components: Platform>Apps Internals>Sandbox>SiteIsolation
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0950ec373d3f263d2d4cad3c258f3c7eb8c545a3

commit 0950ec373d3f263d2d4cad3c258f3c7eb8c545a3
Author: lukasza <lukasza@chromium.org>
Date: Tue Dec 06 21:04:52 2016

Refer to more specific bugs in --site-per-process browser_tests filters.

BUG=671712, 671734

Review-Url: https://codereview.chromium.org/2555863002
Cr-Commit-Position: refs/heads/master@{#436720}

[modify] https://crrev.com/0950ec373d3f263d2d4cad3c258f3c7eb8c545a3/testing/buildbot/filters/site-per-process.browser_tests.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d92b307aa113179dc8cd87bbacce2f555d9ac02

commit 5d92b307aa113179dc8cd87bbacce2f555d9ac02
Author: Charles Reis <creis@chromium.org>
Date: Fri Oct 13 16:53:07 2017

Re-enable several browser_tests in --site-per-process mode.

BUG=417518, 671712, 669299,  670362 
TEST=Site Isolation FYI bots stay green

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ic693f7adc5eb874a3ea5a0fef9e370a2ec79f7e9
Reviewed-on: https://chromium-review.googlesource.com/717943
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508727}
[modify] https://crrev.com/5d92b307aa113179dc8cd87bbacce2f555d9ac02/testing/buildbot/filters/site-per-process.browser_tests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df5d87ddc785e4b383ca3ef2c5f442fd1d1df47

commit 1df5d87ddc785e4b383ca3ef2c5f442fd1d1df47
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Fri Mar 02 01:30:47 2018

Reduce the number of browser_tests excluded in site-per-process mode.

The following tests have mysteriously "healed" themselves and seem to be
passing now:
- IsolatedAppTest.CookieIsolation
- ChromeRenderProcessHostTest.ProcessOverflow
- ChromeRenderProcessHostTest.ProcessPerTab
- ChromeRenderProcessHostTestWithCommandLine.ProcessOverflowCommandLine

The following tests simply needs to adjust their expectations in
site-per-process mode:
- ProcessManagementTest.ExtensionProcessBalancing
- ProcessManagementTest.ProcessOverflow

The following tests no longer exist:
- PrerenderBrowserTest.PrerenderLocationReplaceGWSHistograms

Bug: 671712, 417518
Change-Id: I5fc805da62f468f76ee7091edede8b0b76a5fd0f
Reviewed-on: https://chromium-review.googlesource.com/942103
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540398}
[modify] https://crrev.com/1df5d87ddc785e4b383ca3ef2c5f442fd1d1df47/chrome/browser/extensions/process_management_browsertest.cc
[modify] https://crrev.com/1df5d87ddc785e4b383ca3ef2c5f442fd1d1df47/testing/buildbot/filters/site-per-process.browser_tests.filter

Sign in to add a comment