The iOS CRD app should use the new render tech developed for CRD Android.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9949f5bc318ed45aeadb657d2be743785fe830c7 commit 9949f5bc318ed45aeadb657d2be743785fe830c7 Author: nicholss <nicholss@chromium.org> Date: Thu Jan 05 19:29:17 2017 Moving the GL implementation details into a sub folder for client display. This change with allow me to cleanly add interfaces to the GL implementations. The intent is to add interfaces to the different components, but these get lost in the flat client/ directory. Moving display related files to their own location. R=yuweih@chromium.org BUG= 671692 Review-Url: https://codereview.chromium.org/2614443003 Cr-Commit-Position: refs/heads/master@{#441727} [modify] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/BUILD.gn [modify] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/android/BUILD.gn [modify] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/BUILD.gn [add] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/BUILD.gn [add] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/DEPS [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_canvas.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_canvas.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_cursor.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_cursor.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_cursor_feedback.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_cursor_feedback.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_cursor_feedback_texture.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_cursor_feedback_texture.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_desktop.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_desktop.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_helpers.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_helpers.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_math.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_math.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_render_layer.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_render_layer.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_renderer.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_renderer.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_renderer_delegate.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_renderer_unittest.cc [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/gl_texture_ids.h [rename] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/display/sys_opengl.h [modify] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/ios/example_view_controller.mm [modify] https://crrev.com/9949f5bc318ed45aeadb657d2be743785fe830c7/remoting/client/jni/jni_gl_display_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f62cc8a96c95682f25b90b9f5264b4ecd9c30613 commit f62cc8a96c95682f25b90b9f5264b4ecd9c30613 Author: nicholss <nicholss@chromium.org> Date: Thu Jan 12 16:08:41 2017 Adding drawable to CRD andorid and iOS gl rendering pipeline. This work is to support more generic rendering for mobile platforms. The thinking behind using a stack of 'drawable' objects is we could add future features like fps stats or more animations, and also add debug screens to apps in development for gesture feedback and connection health. R=yuweih@chromium.org BUG= 671692 Review-Url: https://codereview.chromium.org/2591363002 Cr-Commit-Position: refs/heads/master@{#443246} [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/BUILD.gn [add] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/canvas.h [add] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/drawable.h [add] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/fake_canvas.cc [add] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/fake_canvas.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_canvas.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_canvas.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_cursor.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_cursor.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_cursor_feedback.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_cursor_feedback.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_desktop.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_desktop.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_render_layer.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_render_layer.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_renderer.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_renderer.h [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/display/gl_renderer_unittest.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/client/jni/jni_gl_display_handler.cc [modify] https://crrev.com/f62cc8a96c95682f25b90b9f5264b4ecd9c30613/remoting/proto/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b26df2b433fe9371a30f48e8476361ca71546f53 commit b26df2b433fe9371a30f48e8476361ca71546f53 Author: nicholss <nicholss@chromium.org> Date: Thu Jan 19 16:17:15 2017 Migrating host prefrences, runtime, and gestures to chromium from internal. Moving the chromoting iOS app out of internal and into chromium will allow us to find and fix bugs more easily and maintain the codebase without special rights. This CL moves over a bit more of the app to chromium, these files will be used to implemenet a demo app in the pending CL 2555803002. BUG= 671692 Review-Url: https://codereview.chromium.org/2628403002 Cr-Commit-Position: refs/heads/master@{#444756} [modify] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/BUILD.gn [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/app_runtime.cc [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/app_runtime.h [modify] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/bridge/client_instance_unittest.mm [modify] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/bridge/client_proxy.mm [modify] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/bridge/client_proxy_unittest.mm [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/client_gestures.h [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/client_gestures.mm [modify] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/host_preferences.h [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/host_preferences.mm [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/host_preferences_persistence.h [add] https://crrev.com/b26df2b433fe9371a30f48e8476361ca71546f53/remoting/client/ios/host_preferences_persistence_chromium.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859 commit 28f74dd4d3b78681833af7c4ac7fb6b2d8f64859 Author: nicholss <nicholss@chromium.org> Date: Fri Jan 27 16:14:10 2017 Moving source from internal to chromium to provide an app for CRD iOS. Integrating CRD iOS with the new OpenGL renderer. This will allow iOS and android to share a significant amount of render code. It also could be used to build a smoke test of the CRD iOS app in Chromium with similar dependencies to the real app. BUG= 671692 Review-Url: https://codereview.chromium.org/2555803002 Cr-Commit-Position: refs/heads/master@{#446679} [modify] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/branding_Chrome [modify] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/branding_Chromium [modify] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/BUILD.gn [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/BUILD.gn [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/app_delegate.h [rename] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/app_delegate.mm [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/example_view_controller.h [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/example_view_controller.mm [rename] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/main.mm [rename] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/resources/Info.plist [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/app/resources/Remoting.entitlements [delete] https://crrev.com/4c8c6cfe37c424387e26278371125cccbd16d5f3/remoting/client/ios/app_delegate.h [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/display/BUILD.gn [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/display/gl_demo_screen.h [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/display/gl_demo_screen.mm [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/display/gl_display_handler.h [add] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/client/ios/display/gl_display_handler.mm [delete] https://crrev.com/4c8c6cfe37c424387e26278371125cccbd16d5f3/remoting/client/ios/example_view_controller.h [delete] https://crrev.com/4c8c6cfe37c424387e26278371125cccbd16d5f3/remoting/client/ios/example_view_controller.mm [modify] https://crrev.com/28f74dd4d3b78681833af7c4ac7fb6b2d8f64859/remoting/remoting_version.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3 commit 8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3 Author: nicholss <nicholss@chromium.org> Date: Thu Apr 20 20:26:04 2017 Remove crufty bridge code from old CRD iOS app. Moved the app to use the new render in remoting, so this code is no longer needed. R=joedow@chromium.org BUG= 671692 Review-Url: https://codereview.chromium.org/2829853003 Cr-Commit-Position: refs/heads/master@{#466109} [modify] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/remoting/client/display/BUILD.gn [modify] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/remoting/client/ios/BUILD.gn [modify] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/remoting/client/ios/DEPS [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/BUILD.gn [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/DEPS [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_instance.cc [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_instance.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_instance_unittest.mm [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_proxy.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_proxy.mm [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_proxy_delegate.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_proxy_delegate_wrapper.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_proxy_delegate_wrapper.mm [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/client_proxy_unittest.mm [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/frame_consumer_bridge.cc [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/frame_consumer_bridge.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/frame_consumer_bridge_unittest.cc [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/host_proxy.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/host_proxy.mm [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/bridge/host_proxy_unittest.mm [modify] https://crrev.com/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3/remoting/client/ios/display/BUILD.gn [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/utility.h [delete] https://crrev.com/6bb9c7aabd0b66f88400e234b26287cbd64e6ccd/remoting/client/ios/utility.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81 commit acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81 Author: nicholss <nicholss@chromium.org> Date: Fri Apr 21 19:51:26 2017 In order to integrating with the CRD session, we need a delegate to give to the runtime session to be able to ask for the native code to do special actions. This is needed to update how we track the chromoting session in doing real integrations. BUG= 671692 Review-Url: https://codereview.chromium.org/2829673003 Cr-Commit-Position: refs/heads/master@{#466419} [modify] https://crrev.com/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81/remoting/client/chromoting_session.cc [modify] https://crrev.com/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81/remoting/client/chromoting_session.h [modify] https://crrev.com/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81/remoting/client/ios/facade/BUILD.gn [add] https://crrev.com/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81/remoting/client/ios/facade/ios_client_runtime_delegate.h [add] https://crrev.com/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81/remoting/client/ios/facade/ios_client_runtime_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b31d544a5feacdf41081c52d61cacc5cb5bc10ae commit b31d544a5feacdf41081c52d61cacc5cb5bc10ae Author: nicholss <nicholss@chromium.org> Date: Fri Apr 21 23:12:07 2017 This cl connects a dummy pin to the session delegate in order to test out the connection authentication flow. BUG= 671692 Review-Url: https://codereview.chromium.org/2827163004 Cr-Commit-Position: refs/heads/master@{#466485} [modify] https://crrev.com/b31d544a5feacdf41081c52d61cacc5cb5bc10ae/remoting/client/ios/session/BUILD.gn [modify] https://crrev.com/b31d544a5feacdf41081c52d61cacc5cb5bc10ae/remoting/client/ios/session/remoting_client.h [modify] https://crrev.com/b31d544a5feacdf41081c52d61cacc5cb5bc10ae/remoting/client/ios/session/remoting_client.mm [modify] https://crrev.com/b31d544a5feacdf41081c52d61cacc5cb5bc10ae/remoting/client/ios/session/remoting_client_session_delegate.h [modify] https://crrev.com/b31d544a5feacdf41081c52d61cacc5cb5bc10ae/remoting/client/ios/session/remoting_client_session_delegate.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a204e74f7bbea5269fd0b8ff221d5ea42f524552 commit a204e74f7bbea5269fd0b8ff221d5ea42f524552 Author: nicholss <nicholss@chromium.org> Date: Mon Apr 24 22:28:50 2017 This CL is about plumbing the required information from the HostInfo objects and passing that to the session creation methods. It also cleans up responsibilities for which object holds and creates the rendering and client connections, pushing that into the client session rather than the view (from another CL, integrated here). Also integrating with new rendering for CRD iOS for the gl rendering client. Also making the FAB smaller on host view. Moving https://codereview.chromium.org/2828113002/ to this cl. BUG= 671692 Review-Url: https://codereview.chromium.org/2828113002 Cr-Commit-Position: refs/heads/master@{#466797} [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/BUILD.gn [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/app/host_collection_view_cell.h [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/app/host_collection_view_cell.mm [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/app/host_collection_view_controller.mm [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/app/host_view_controller.h [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/app/host_view_controller.mm [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/app/remoting_view_controller.mm [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/display/gl_demo_screen.mm [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/display/gl_display_handler.h [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/display/gl_display_handler.mm [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/facade/remoting_service.h [modify] https://crrev.com/a204e74f7bbea5269fd0b8ff221d5ea42f524552/remoting/client/ios/facade/remoting_service.mm
This has been integrated and we are getting video, though not optimized yet. Some refactoring has to be done to finish out the app but the integration has been done.
Comment 1 by jamiewa...@chromium.org
, Dec 6 2016