New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671686 link

Starred by 1 user
Status: Fixed
Owner:
█ dfalcant...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ dim...@chromium.org
fgor...@chromium.org
█ talo@chromium.org
█ rachelis@chromium.org
dougarnett@chromium.org
█ dfalcant...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 658744



Sign in to add a comment

Download pending notification icon should be 40% transparent

Project Member Reported by dah...@chromium.org, Dec 6 2016 
Min recently updated the icon for the download pending notification from animated to non-animated. We would like to change the icon to 40% transparent in order to ensure that users don't misunderstand the icon and think that the file is downloaded. Min mentioned this may require a new resource. 

Dan, given that Min is out, is this something you could take on?

Comment 1 by dah...@chromium.org, Dec 7 2016

Cc: -qin...@chromium.org dfalcant...@chromium.org
Owner: rachelis@chromium.org
Rachel, can you add the updated resource to the bug?

Comment 2 by dah...@chromium.org, Dec 8 2016

Labels: ReleaseBlock-Stable

Comment 3 by rachelis@google.com, Dec 14 2016

Cc: rachelis@chromium.org
Owner: dfalcant...@chromium.org
Thanks for your patience with all the file-chasing. For documentation, it took us some time to chase down where the files are located in order to tweak them. We were unable to access source files. Rachel Garb is the contact point on Android for further assistance. 
https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDQlR2NVExMUQ4ZVE

I've exported the assets and attached them here - it looks like I don't have access to this folder in order to place them. Dan, can you please add them there?
stat_sys_download_anim0-a40-hdpi.png
478 bytes View Download
stat_sys_download_anim0-a40-mdpi.png
381 bytes View Download
stat_sys_download_anim0-a40-xhdpi.png
577 bytes View Download
stat_sys_download_anim0-a40-xxhdpi.png
515 bytes View Download
download+pause.sketch
48.0 KB Download
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6e6701fb26406f53793a5b6497643cda638459

commit aa6e6701fb26406f53793a5b6497643cda638459
Author: dfalcantara <dfalcantara@chromium.org>
Date: Wed Dec 14 23:49:28 2016

[Download notifications] Replace images

Replace Android pause and pending images with UX-provided ones.

BUG= 671686 ,671130

Review-Url: https://codereview.chromium.org/2570403002
Cr-Commit-Position: refs/heads/master@{#438679}

[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-hdpi/ic_download_pause.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-hdpi/ic_download_pending.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-mdpi/ic_download_pause.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-mdpi/ic_download_pending.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-xhdpi/ic_download_pause.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-xhdpi/ic_download_pending.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-xxhdpi/ic_download_pause.png
[add] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/res/drawable-xxhdpi/ic_download_pending.png
[modify] https://crrev.com/aa6e6701fb26406f53793a5b6497643cda638459/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Comment 5 by dfalcant...@chromium.org, Dec 14 2016

Labels: Merge-Request-56

Comment 6 by dimu@chromium.org, Dec 15 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8305141334b8ab7937f1a21faf65f866e8329b21

commit 8305141334b8ab7937f1a21faf65f866e8329b21
Author: dfalcantara@chromium.org <dfalcantara@chromium.org>
Date: Thu Dec 15 01:50:30 2016

[Download notifications] Replace images

Replace Android pause and pending images with UX-provided ones.

BUG= 671686 ,671130
TBR=twellington@chromium.org

Original-Review-Url: https://codereview.chromium.org/2570403002
Original-Cr-Commit-Position: refs/heads/master@{#438679}
Review-Url: https://codereview.chromium.org/2581553002 .
Cr-Commit-Position: refs/branch-heads/2924@{#505}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-hdpi/ic_download_pause.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-hdpi/ic_download_pending.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-mdpi/ic_download_pause.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-mdpi/ic_download_pending.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-xhdpi/ic_download_pause.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-xhdpi/ic_download_pending.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-xxhdpi/ic_download_pause.png
[add] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/res/drawable-xxhdpi/ic_download_pending.png
[modify] https://crrev.com/8305141334b8ab7937f1a21faf65f866e8329b21/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Comment 8 by dfalcant...@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment