New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671682 link

Starred by 1 user
Status: Assigned
Owner:
dlaurie@chromium.org
Cc:
adurbin@chromium.org
█ dhend...@chromium.org
afakhry@chromium.org
semenzato@chromium.org
█ sha...@chromium.org
dlaurie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mosys: elog "SUS Power Fail" messages scare people

Project Member Reported by sha...@chromium.org, Dec 6 2016 
Sometimes people get scared and report "SUS Power Fail" elog messages as possible bugs when things are actually functioning correctly. How about we change this to "SUS Power Down" or "SUS Power Lost"? We can change all of these strings in a similar way:

		{ ELOG_TYPE_POWER_FAIL, "Power Fail" },
		{ ELOG_TYPE_SUS_POWER_FAIL, "SUS Power Fail" },
		{ ELOG_TYPE_PWROK_FAIL, "PWROK Fail" },
		{ ELOG_TYPE_SYS_PWROK_FAIL, "SYS PWROK Fail" },

Comment 1 by semenzato@chromium.org, Dec 6 2016

Cc: afakhry@chromium.org
Many people (sheriffs and others) need to look at these logs with no knowledge of the code that produces them, and we should help them make educated guesses about what goes on.

"Fail" and "lost" aren't good choices.  How about "Off".

Comment 2 by dhend...@chromium.org, Dec 6 2016

Cc: dlaurie@chromium.org
Yeah, I was actually thrown off by the "SUS Power Fail" message the first time I saw it in an eventlog. Intel's own documentation uses "failure" in the bit descriptions even though it's the result of a normal shutdown, so the terminology is somewhat misleading.

I think "off" is good. Though we do need to be careful not to mask a real failure.

Comment 3 by reinauer@chromium.org, Mar 31 2017

Owner: dlaurie@chromium.org
Status: Assigned (was: Untriaged)
Duncan, I'm hesitant renaming these messages as this is terminology that is used in vendor documents across the industry. Shall we abandon this?
►

Sign in to add a comment