arc: Unknown error on auth code failure |
|||||
Issue descriptionInner bug: b/33347895 There is unknown error in case auth code fetch failed for silent sign in. This is regression and before it showed IDS_ARC_SERVER_COMMUNICATION_ERROR error. We have to restore this in order to start finch experiment for enable silent sign-in
,
Dec 7 2016
,
Dec 7 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a622acd40895de932bf7afda1f5f244085ad710d commit a622acd40895de932bf7afda1f5f244085ad710d Author: khmel <khmel@chromium.org> Date: Wed Dec 07 21:39:01 2016 [Merge-M56] arc: Fix double provisioning failure reporting. In case a auth code request failure occurs, error is reported. In many cases this causes Arc bridge stop and mojo close. On mojo close Cancel exception is reported to Arc provision step. It itself sends one more Unknown error that overrides previous error. This CL ignore second and next error. TEST=Manually on device. Emulate server error and instead unknown error server communication error is shown. BUG=b/33347895 BUG= 671667 TBR=lhchavez@chromium.org TBR=hidehiko@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2554743003 Cr-Commit-Position: refs/heads/master@{#436794} (cherry picked from commit 42d24efdbeff42ab083b9d3b59ddb1a4753b370e) Review-Url: https://codereview.chromium.org/2556273002 Cr-Commit-Position: refs/branch-heads/2924@{#390} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/a622acd40895de932bf7afda1f5f244085ad710d/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/a622acd40895de932bf7afda1f5f244085ad710d/chrome/browser/chromeos/arc/arc_auth_service.h [modify] https://crrev.com/a622acd40895de932bf7afda1f5f244085ad710d/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc
,
Dec 7 2016
,
Jan 23 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Dec 7 2016