Screenshots:
old-normal: dialog before https://codereview.chromium.org/2558483002/
old-harmony: dialog before https://codereview.chromium.org/2558483002/ with Harmony
new-normal: dialog after https://codereview.chromium.org/2558483002/
new-harmony: dialog after https://codereview.chromium.org/2558483002/ with Harmony

Deleted: old-normal.png 12.7 KB

	old-normal.png 12.7 KB View Download

Deleted: old-harmony.png 12.5 KB

	old-harmony.png 12.5 KB View Download

Deleted: new-normal.png 12.5 KB

	new-normal.png 12.5 KB View Download

Deleted: new-harmony.png 12.6 KB

	new-harmony.png 12.6 KB View Download

Is it worth having a general tracking bug for all extension bubbles (or all extension ui) that tracks harmony conversion?  Either that this could be a blocker of, or repurpose this bug to be that?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d30f44b11887d895ce436b4e8c977b2ddbaec3f

commit 7d30f44b11887d895ce436b4e8c977b2ddbaec3f
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Dec 06 18:46:57 2016

views: convert ToolbarActionsBarBubble to Harmony

BUG=671656

Review-Url: https://codereview.chromium.org/2558483002
Cr-Commit-Position: refs/heads/master@{#436660}

[modify] https://crrev.com/7d30f44b11887d895ce436b4e8c977b2ddbaec3f/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

State as of current trunk.

shrike@, what do you think of this?

Deleted: devmode.png 12.0 KB

	devmode.png 12.0 KB View Download

Looks good. Only a couple changes:

* Button widths should be the same (currently Disable is a few pts wider)
* The distance between the dialog text and the top of the buttons be 24pt (from looking at https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20extensions_01.png%3Fz=width)

Also the dialog title should be title case on the Mac (I know this is not a Mac screenshot).

Something we changed recently made this dialog absurdly wide (attached). I'm looking into why now.

Deleted: Screen Shot 2017-04-25 at 9.34.08 AM.png 26.3 KB

	Screen Shot 2017-04-25 at 9.34.08 AM.png 26.3 KB View Download

views::Widget::GetLocalizedContentsWidth(IDS_EXTENSION_TOOLBAR_REDESIGN_NOTIFICATION_BUBBLE_WIDTH_CHARS) is returning 362 on my linux machine but 605 (!!) on my Mac. Looking at why...

The width problem is  issue 654128  I think; I have a fix CL up for it. I'll revisit this bug after that.

I went back to this dialog today.

a) I validated that the title is indeed title case on Mac
b) The buttons are now the same width exactly

Sending this one to bettes@ for review.

 Issue 654128  has been merged into this issue.

From the other bug: "The most obvious things that stick out to me are the use of "Learn more" instead of "(?)", the width of the dialog, and the highlight shape and color (shape may be an artifact of the test, color may be intentional).  Oh, also, since this is a popover, I think it should have a close X?"

Elly/Alan to check if any of those concerns are valid.

On trunk, it looks like the attached image.

Specific issues mentioned:

1) We do use "Learn More" instead of "(?)" still - the latest spec I've seen (the one in the HTML renders named "03 - Extensions_disable_extension" or similar) uses a "Learn More" link, but appended to the text instead of in the bottom-left. Is there a mock that has the "(?)" approach or shows what it looks like (or where it goes in the dialog)?

2) The width is 448 right now, I think - we could clamp it to 320 using the same technique used in 12d3545c. I'm not sure what it's supposed to be.

3) I'm not sure what's up with the highlight shape. It's pretty big but I think that's just an aggressive amount of spacing around the icon; see dev-highlight.png attached for an example. The color is deliberate, as far as i can tell.

I'm not sure about a close X. It has an explicit cancel button.

Deleted: devmode.png 12.7 KB

	devmode.png 12.7 KB View Download

Deleted: dev-highlight.png 1.0 KB

	dev-highlight.png 1.0 KB View Download

(?) should go in the bottom-left corner, where the "Learn more" in your image goes.  Offhand I think we might have this in mocks for the content setting bubbles?

For the close X, presumably we'd remove the cancel button if we added an 'X', and we're supposed to add an 'X' since this is non-modal, but admittedly I never remember the rules on close 'X's very well.

c15 - close x on popovers

 crbug.com/707264 : Ensure all popover dialogs have close X, no redundant cancel buttons (Note: remove redundant cancel if possible. It's not a hard requirement especially for Harmony V1.)

Here's the bubble with the close (X) and clamped to 320. The Learn More link and Cancel button are a lot trickier to remove due to the manner in which the code is layered.

Deleted: DeveloperModeExtension.png 22.4 KB

	DeveloperModeExtension.png 22.4 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e69f3297bbf02533c0b72540086d67a02939fd5

commit 6e69f3297bbf02533c0b72540086d67a02939fd5
Author: Allen Bauer <kylixrd@chromium.org>
Date: Thu Feb 08 15:02:31 2018

Harmony: Add Close (x) and clamp width to 320 to ToolBarActionsBarBubble

Bug: 671656
Change-Id: I0b246d250ce3ed7d6d12d283e6b2ccff512180a3
Reviewed-on: https://chromium-review.googlesource.com/907111
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535376}
[modify] https://crrev.com/6e69f3297bbf02533c0b72540086d67a02939fd5/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc
[modify] https://crrev.com/6e69f3297bbf02533c0b72540086d67a02939fd5/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h

There are other bubbles which use the same underlying infrastructure that have two buttons, but the "disable developer mode extensions" bubble looks to be the only one that has a button actually called "Cancel". I've also been able to get the "Learn more" link turned into the (?) image button.

Deleted: DeveloperModeExtensionNoCancel.png 17.0 KB

	DeveloperModeExtensionNoCancel.png 17.0 KB View Download

This is the NTP Override warning bubble. The title is wrapping at 320 and the buttons are a little cramped. "Keep changes" is the "cancel" button. Should it also be removed?

Deleted: NTPOverride.png 7.2 KB

	NTPOverride.png 7.2 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6de866ade456810e3105dfa33980b4c2c1325188

commit 6de866ade456810e3105dfa33980b4c2c1325188
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Feb 13 21:15:34 2018

Harmony: Make Learn More link into a (?) button and remove Cancel button from DevModeBubbleDelegate.

Adjust unit tests. Removed delegate methods that are never called.

TBR=tapted@chromium.org

Bug: 671656
Change-Id: I406f9080772c801d6cc95c01a410ba3fb680f0a9
Reviewed-on: https://chromium-review.googlesource.com/909229
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536479}
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/extensions/dev_mode_bubble_delegate.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/extensions/blocked_action_bubble_delegate.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/extensions/blocked_action_bubble_delegate.h
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/extensions/extension_message_bubble_bridge.h
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h
[modify] https://crrev.com/6de866ade456810e3105dfa33980b4c2c1325188/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc

***Mass UI Triage***

kylixrd@ could you please help in verifying the issue?