New issue
Advanced search Search tips

Issue 671653 link

Starred by 2 users
Status: Fixed
Owner:
siggi@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Chrome.dll should allocate its own heap

Project Member Reported by siggi@chromium.org, Dec 6 2016 
This will reduce contention on the heap (slightly), will make it easier to instrument Chrome's heap usage with existing Windows tools, and will make it easier to separate Chrome's own usage from the "systems".
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82535f6c4c3d582c7a60d941b8402a45c9e99e6b

commit 82535f6c4c3d582c7a60d941b8402a45c9e99e6b
Author: siggi <siggi@chromium.org>
Date: Tue Dec 06 22:29:03 2016

Change the CRT initialization to create a new heap for Chrome.dll.

Also change the malloc provider to iterate over the CRT's heap.

BUG= 671653 

Review-Url: https://codereview.chromium.org/2552333002
Cr-Commit-Position: refs/heads/master@{#436760}

[modify] https://crrev.com/82535f6c4c3d582c7a60d941b8402a45c9e99e6b/base/allocator/allocator_shim_override_ucrt_symbols_win.h
[modify] https://crrev.com/82535f6c4c3d582c7a60d941b8402a45c9e99e6b/base/allocator/allocator_shim_unittest.cc
[modify] https://crrev.com/82535f6c4c3d582c7a60d941b8402a45c9e99e6b/base/trace_event/malloc_dump_provider.cc

Comment 2 by siggi@chromium.org, Dec 7 2016

Status: Started (was: Untriaged)
Keeping this bug open while I verify that this doesn't negatively affect memory usage metrics.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb93a524deced49ea1d5620479ea449dc0896e7

commit 7fb93a524deced49ea1d5620479ea449dc0896e7
Author: siggi <siggi@chromium.org>
Date: Mon Dec 12 22:22:15 2016

Iterate CRT heap instead of process heap.

BUG=671459, 671653 

Review-Url: https://codereview.chromium.org/2569753002
Cr-Commit-Position: refs/heads/master@{#437930}

[modify] https://crrev.com/7fb93a524deced49ea1d5620479ea449dc0896e7/content/renderer/render_thread_impl.cc

Comment 4 by siggi@chromium.org, Feb 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment