Issue 671651 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	kylec...@chromium.org
Closed:	Feb 2017
Cc:	rjkroege@chromium.org mustash-bugs@google.com
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Feature
Proj-Mustash-Mus mustash-display VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 548429

mustash ScreenManager uses DC+DCO+DM

Project Member Reported by kylec...@chromium.org, Dec 6 2016

Issue description

In mustash ScreenManager should use DisplayConfigurator + DisplayChangeObserver + DisplayManager. This is the same setup that classic ash uses now where ash::Shell owns those three objects.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4cdc4429dc5e480b35e88bb781e78fdc1592478

commit f4cdc4429dc5e480b35e88bb781e78fdc1592478
Author: kylechar <kylechar@chromium.org>
Date: Wed Dec 21 04:29:18 2016

mustash: ScreenManagerOzone uses DCO and DM.

ScreenManagerOzone will uses DisplayChangeObserver and DisplayManager
for display management. DCO listens for changes to displays and forwards
those to DM. These are the same components used in classic ash.

BUG= 671651 

Review-Url: https://codereview.chromium.org/2476663003
Cr-Commit-Position: refs/heads/master@{#440014}

[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/BUILD.gn
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/BUILD.gn
[add] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/run_all_unittests.cc
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/screen_manager_ozone.cc
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/screen_manager_ozone.h
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/screen_manager_ozone_unittests.cc
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/viewport_metrics.cc
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/services/ui/display/viewport_metrics.h
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/ui/display/manager/display_manager.cc
[modify] https://crrev.com/f4cdc4429dc5e480b35e88bb781e78fdc1592478/ui/display/manager/display_manager.h

Comment 2 by jamescook@chromium.org, Jan 6 2017

Will this eliminate ash::Shell::GetInstance()->display_configurator() calls from src/chrome?

Comment 3 by kylec...@chromium.org, Jan 6 2017

No it will not. This bug just entails that mus-ws has the same core display management code running that classic ash uses. Getting all of the code that interfaces with core display management to work over IPC is another task.

I've filled  crbug.com/678951  as a tracking bug for getting display management related code to work across processes.