New issue
Advanced search Search tips

Issue 671627 link

Starred by 1 user
Status: Fixed
Owner:
donnd@chromium.org
Closed: Dec 2016
Cc:
twelling...@chromium.org
donnd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testLongPressSwipeExpand" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 6 2016 
"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testLongPressSwipeExpand" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybAsSBUZsYWtlImFvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY29udGV4dHVhbHNlYXJjaC5Db250ZXh0dWFsU2VhcmNoTWFuYWdlclRlc3QjdGVzdExvbmdQcmVzc1N3aXBlRXhwYW5kDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by jbudorick@chromium.org, Dec 6 2016

Cc: twelling...@chromium.org donnd@chromium.org
Labels: OS-Android
Status: Available (was: Untriaged)
Of the three recent flakes, two failed with the following:

org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testLongPressSwipeExpand (run #1):
junit.framework.AssertionFailedError: Panel did not enter PEEKED state. Instead, the current state is UNDEFINED.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:691)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToPeek(ContextualSearchManagerTest.java:657)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.longPressNode(ContextualSearchManagerTest.java:197)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testLongPressSwipeExpand(ContextualSearchManagerTest.java:1143)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

while the third failed with:

org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testLongPressSwipeExpand (run #1):
junit.framework.AssertionFailedError: Panel did not enter EXPANDED state. Instead, the current state is PEEKED.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:691)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToExpand(ContextualSearchManagerTest.java:665)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testLongPressSwipeExpand(ContextualSearchManagerTest.java:1159)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Comment 2 by rogerta@chromium.org, Dec 6 2016 

The most recent occurrence of this error happened in build #192970, which is more that 200 builds ago, or 5 days ago.  Seems like something was fixed since then?

Comment 3 by rogerta@chromium.org, Dec 6 2016

Labels: -Sheriff-Chromium

Comment 4 by jbudorick@chromium.org, Dec 6 2016 

192970 was on Monday.

Comment 5 by jbudorick@chromium.org, Dec 6 2016 

... that is, yesterday afternoon.

(Somehow I'm already thinking it's Wednesday...)

Comment 6 by donnd@chromium.org, Dec 6 2016

Components: UI>Browser>Mobile>TouchToSearch
Owner: donnd@chromium.org
Status: Assigned (was: Available)
I'll take a look at this tonight.
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Dec 7 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testLongPressSwipeExpand". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybAsSBUZsYWtlImFvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY29udGV4dHVhbHNlYXJjaC5Db250ZXh0dWFsU2VhcmNoTWFuYWdlclRlc3QjdGVzdExvbmdQcmVzc1N3aXBlRXhwYW5kDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 8 by twelling...@chromium.org, Dec 7 2016 

Donn, we could start by adding @RetryOnFailure to the test; it's an old test that's unlikely to have been affected by anything we've modified recently.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dea2db07061597d1cc4b30e087286ebe5e90383

commit 8dea2db07061597d1cc4b30e087286ebe5e90383
Author: donnd <donnd@chromium.org>
Date: Thu Dec 08 01:40:59 2016

[TTS] Fix testLongPressSwipeExpand flakiness.

Rework testLongPressSwipeExpand to use the newer way of starting
a search and a more robust way to expand the panel.

Hopefully that this makes this test less flaky.

BUG= 671627 

Review-Url: https://codereview.chromium.org/2559003002
Cr-Commit-Position: refs/heads/master@{#437121}

[modify] https://crrev.com/8dea2db07061597d1cc4b30e087286ebe5e90383/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 10 by treib@chromium.org, Dec 8 2016

Labels: -Sheriff-Chromium
Removing this from the sheriff queue, assuming the flakiness was addressed.

Comment 11 by donnd@chromium.org, Dec 8 2016

Status: Fixed (was: Assigned)
Looks like this fixed the problem, reopen if needed.
►

Sign in to add a comment