New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671618 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Leaves the project on 2018/03/02
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

.../websocket/workers/worker-....html tests are flaky

Project Member Reported by hbos@chromium.org, Dec 6 2016

Issue description

Tests flaking on WebKit Linux Trusty Leak:

  http/tests/websocket/workers/worker-reload.html [ Timeout ]
  virtual/mojo-loading/http/tests/websocket/workers/worker-reload.html [ Timeout ]
  virtual/mojo-loading/http/tests/websocket/workers/worker-shutdown-race.html [ Timeout ]

Examples:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/529/steps/webkit_tests/logs/stdio

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/528/steps/webkit_tests/logs/stdio

ricea can you please take a look or reassign?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4053d6fde2ae5df4bc1e18255d5db3fe1c3124

commit 9f4053d6fde2ae5df4bc1e18255d5db3fe1c3124
Author: hbos <hbos@chromium.org>
Date: Tue Dec 06 14:58:45 2016

Allowing some flaky websocket/workers/worker-*.html tests to timeout.

BUG= 671618 
TBR=ricea@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2552923003
Cr-Commit-Position: refs/heads/master@{#436596}

[modify] https://crrev.com/9f4053d6fde2ae5df4bc1e18255d5db3fe1c3124/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by ricea@chromium.org, Dec 7 2016

Cc: tyoshino@chromium.org yhirano@chromium.org
Components: Blink>Network>WebSockets
Labels: OS-All
Owner: ----
Status: Available (was: Assigned)
Un-assigning as I will be out for the rest of the month.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc595432d97064286db8e2bdda3d8eb2119dbfc

commit fdc595432d97064286db8e2bdda3d8eb2119dbfc
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Dec 07 19:49:24 2016

Update TestExpectations by running Tools/Scripts/update-test-expectations.

This script removes lines for tests that appear to no longer flakily fail or timeout on the applicable platforms, according to recent results on the flakiness dashboard.

BUG=248938,446385, 513143 ,518987,522647, 532643 , 564403 , 569901 , 581468 , 605525 , 658311 , 658414 ,660308, 667953 , 671618 

Review-Url: https://codereview.chromium.org/2557593006
Cr-Commit-Position: refs/heads/master@{#437038}

[modify] https://crrev.com/fdc595432d97064286db8e2bdda3d8eb2119dbfc/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by treib@chromium.org, Dec 8 2016

Components: Tests>Flaky
Owner: tyoshino@chromium.org
Status: Assigned (was: Available)
These tests are still timing out, and I'll add the Timeout expectations back.

tyoshino, can you please take a look and/or help triage?
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14a1c51ef90df5e653e6e2305b5d4783d38af80f

commit 14a1c51ef90df5e653e6e2305b5d4783d38af80f
Author: treib <treib@chromium.org>
Date: Thu Dec 08 10:12:56 2016

Add back Timeout expectations for websocket worker tests

These were removed in https://codereview.chromium.org/2557593006,
but turns out these tests still time out.

TBR=qyearsley@chromium.org
NOTRY=true

BUG= 672407 , 671618 

Review-Url: https://codereview.chromium.org/2559133002
Cr-Commit-Position: refs/heads/master@{#437225}

[modify] https://crrev.com/14a1c51ef90df5e653e6e2305b5d4783d38af80f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14e61ec0e68c462c4f0e4018aae63e5be261d615

commit 14e61ec0e68c462c4f0e4018aae63e5be261d615
Author: flackr <flackr@chromium.org>
Date: Thu Dec 08 15:33:23 2016

Add expected timeout for flaky test worker-shutdown-race.html

TBR=qyearsley@chromium.org
NOTRY=true

BUG= 672493 , 671618 

Review-Url: https://codereview.chromium.org/2565513002
Cr-Commit-Position: refs/heads/master@{#437247}

[modify] https://crrev.com/14e61ec0e68c462c4f0e4018aae63e5be261d615/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d46fa5ac846fdac9c6734a7c10d3d5eadff55f1

commit 7d46fa5ac846fdac9c6734a7c10d3d5eadff55f1
Author: yhirano <yhirano@chromium.org>
Date: Tue Jan 24 06:53:31 2017

websocket/workers/worker-shutdown-race.html is no longer flaky

BUG= 671618 ,  672493 
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2657543002
Cr-Commit-Position: refs/heads/master@{#445669}

[modify] https://crrev.com/7d46fa5ac846fdac9c6734a7c10d3d5eadff55f1/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b034403ab50b3a27bda35d6cf72efec57f2f1217

commit b034403ab50b3a27bda35d6cf72efec57f2f1217
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Feb 07 17:50:47 2017

Remove flaky expectations with update-test-expectations script

The update-test-expectations script is meant to remove
flaky expectations when it appears that according to the
most recent results on the flakiness dashboard for that test,
the test is no longer flaky.

BUG= 491764 , 498539 , 575766 , 600248 ,658305, 663838 , 663840 ,663848, 663851 , 663853 , 663872 , 663874 , 663877 , 663879 ,664817,664839, 664840 , 664841 , 664842 , 664846 , 664850 , 664855 , 664856 , 666991 , 671480 , 671618 , 672204 , 673296 , 673632 , 674720 ,674858, 678488 , 683800 

Review-Url: https://codereview.chromium.org/2679543005
Cr-Commit-Position: refs/heads/master@{#448663}

[modify] https://crrev.com/b034403ab50b3a27bda35d6cf72efec57f2f1217/third_party/WebKit/LayoutTests/TestExpectations

The update-test-expectations script removed the flaky expectations because the recent results on the flakiness dashboard indicated that they pass consistently... this may not be an issue now?
Status: Fixed (was: Assigned)
worker-reload.html still times out occasionally on the slower bots, but flakiness is down to 0.04% and we have bigger fish to fry.

worker-shutdown-race.html seems to be flaky on the v8_linux_blink_rel bot for some reason. It's at 0.05%, so not sensible to spend time on.

Closing.

Sign in to add a comment