Removing link element from shadow tree marks wrong treeScope dirty
Reported by
r...@opera.com,
Dec 6 2016
|
||
Issue descriptionWhen removing a link element from a shadow tree, we incorrectly mark the document tree scope dirty. We are currently saved by the FullStyleUpdate in HTMLLinkElement::removedFrom, but working on issue 567021 revealed this issue.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eabd1355eb5582a0abfb900ba1d398c3b44a41ff commit eabd1355eb5582a0abfb900ba1d398c3b44a41ff Author: rune <rune@opera.com> Date: Thu Dec 08 08:28:00 2016 Mark correct tree-scope dirty removing link in shadow. Noticed while working on 567021, StyleElement found the correct tree-scope in from of a shadow root when applicable while HTMLLinkElement would just use the document. This is what kept us from being able to use AnalyzedStyleUpdate for removedFrom() for link elements. R=meade@chromium.org BUG= 671596 Review-Url: https://codereview.chromium.org/2554873002 Cr-Commit-Position: refs/heads/master@{#437210} [modify] https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff/third_party/WebKit/LayoutTests/shadow-dom/host-link-style.html [modify] https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp [modify] https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff/third_party/WebKit/Source/core/dom/StyleElement.cpp [modify] https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff/third_party/WebKit/Source/core/dom/StyleEngine.cpp [modify] https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff/third_party/WebKit/Source/core/dom/StyleEngine.h [modify] https://crrev.com/eabd1355eb5582a0abfb900ba1d398c3b44a41ff/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
,
Dec 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by r...@opera.com
, Dec 6 2016Labels: OS-All