Do we really need to upstream this file? All app (Chrome, all unit tests and all eg tests) use the fake hooks, so what about just removing the function once we drop KIF instead.

We don't use a test hook for EG tests?  Are EG tests running omaha and firstrun?

There's an EG hook at chrome/test/earl_grey/eg_tests_hook.mm.

Oh, missed that one. Sorry for the noise. We should not upstream SetUpKIFTestsIfPresent/RunKIFTestsIfPresent though. Right?

I've kept it in my first pass, depends on how quickly we delete kif tests, or whether we delete them at all.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfb38253441460834d4667833f7a25a884ac5a68

commit dfb38253441460834d4667833f7a25a884ac5a68
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Dec 06 15:33:50 2016

[ios] Adds test hooks to enable/disable functionality while testing.

BUG= 671589 

Review-Url: https://codereview.chromium.org/2557613004
Cr-Commit-Position: refs/heads/master@{#436603}

[modify] https://crrev.com/dfb38253441460834d4667833f7a25a884ac5a68/ios/chrome/app/BUILD.gn
[add] https://crrev.com/dfb38253441460834d4667833f7a25a884ac5a68/ios/chrome/app/tests_fake_hook.mm
[add] https://crrev.com/dfb38253441460834d4667833f7a25a884ac5a68/ios/chrome/app/tests_hook.h

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8a429fa6812a5b912f11e563e8fe53ca87ae1ca9

commit 8a429fa6812a5b912f11e563e8fe53ca87ae1ca9
Author: rohitrao <rohitrao@google.com>
Date: Tue Dec 06 19:02:47 2016