New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671580 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
inactive
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression

Blocking:
issue 675390
issue 680395



Sign in to add a comment

"Request Desktop site" sticks after pressing back button

Project Member Reported by sanjoy....@samsung.com, Dec 6 2016

Issue description

Chrome Version: (copy from chrome://version)
OS: Android

What steps will reproduce the problem?
(1) fetch cnn.com
(2) Click on any new link.
(3) Change to "Request Desktop Site"
(4) Press back key to go back to cnn.com homepage

What happens instead?
cnn.com homepage is rendered with larger viewport width in mobile version.

Please use labels and text to provide additional information.

This is a regression of https://codereview.chromium.org/1785953002


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
Summary: "Request Desktop site" sticks after pressing back button (was: Layout issue while toggling "Request Desktop site")
Similar issue  crbug.com/675390 
Blocking: 675390
Blocking: -675390
Blocking: 675390
Cc: aelias@chromium.org
 Issue 675390  has been merged into this issue.
Blocking: 680395
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/100c919f8fc51a06aee219a6898424f006cca92a

commit 100c919f8fc51a06aee219a6898424f006cca92a
Author: aelias <aelias@chromium.org>
Date: Fri Jan 13 00:01:43 2017

Update viewport_meta setting on any navigation.

In http://crrev.com/1785953002 I tied a setting to the
is_overriding_user_agent property of NavigationEntry, but I forgot to
keep the preference updated during arbitrary navigation entry changes
(e.g. back button).

BUG= 671580 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2619063003
Cr-Commit-Position: refs/heads/master@{#443399}

[modify] https://crrev.com/100c919f8fc51a06aee219a6898424f006cca92a/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/100c919f8fc51a06aee219a6898424f006cca92a/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/100c919f8fc51a06aee219a6898424f006cca92a/content/test/test_render_view_host.cc
[modify] https://crrev.com/100c919f8fc51a06aee219a6898424f006cca92a/content/test/test_render_view_host.h

Comment 9 by aelias@chromium.org, Jan 13 2017

Status: Fixed (was: Assigned)
Cc: dfalcant...@chromium.org k...@chromium.org creis@chromium.org tedc...@chromium.org
 Issue 691835  has been merged into this issue.

Sign in to add a comment