Regression : Page source font size does not change according to the default font size.
Reported by
yfulgaon...@etouch.net,
Dec 6 2016
|
||||||
Issue descriptionChrome Version : 57.0.2943.0 (Official Build) d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba-refs/heads/master@{#436483} 64 bit OS : Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings/fonts and decrease the ‘Font size’ slider to the extreme end. 2. Click on back arrow icon (on subpage) and in ‘Appearance’ section, set ‘Page zoom’ level to 125% then reload the page. 3. Now again set ‘Page zoom’ level to “100%” and ‘Font size’ to “Medium”. 4. Right click on page and select ‘View page source’, observe the font in page source. Actual : Page source font size does not change according to the default font size. Expected : Page source font size should change according to the default font size. This is a regression issue broken in ‘M-53’, below is the Manual Regression range and narrow bisect info. Good build : 53.0.2769.0 Bad build : 53.0.2770.0 Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/310987a58f614f8313671ce5a0faf7e70bbd0929..0b61879559c9c6d768d7c13b8ad25eebc2b2437d?pretty=fuller&n=10000 Suspecting : r 400070 from Narrow Bisect
,
Apr 15 2017
,
Apr 15 2017
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7cd6a5130a7a261ae997c5e37dc4fec4560cff3 commit b7cd6a5130a7a261ae997c5e37dc4fec4560cff3 Author: dschuyler <dschuyler@chromium.org> Date: Mon Apr 17 23:12:40 2017 [MD settings] observe changes to default font size in Appearance This CL updates the fixed font size from the Appearance section reliably. (It was previously working depending on which settings page had been visited). Also, updates the UI to remove the font size on the example of the fixed font size. BUG= 671562 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817243003 Cr-Commit-Position: refs/heads/master@{#465054} [modify] https://crrev.com/b7cd6a5130a7a261ae997c5e37dc4fec4560cff3/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html [modify] https://crrev.com/b7cd6a5130a7a261ae997c5e37dc4fec4560cff3/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js [modify] https://crrev.com/b7cd6a5130a7a261ae997c5e37dc4fec4560cff3/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/b7cd6a5130a7a261ae997c5e37dc4fec4560cff3/chrome/browser/resources/settings/appearance_page/appearance_page.js
,
Apr 17 2017
,
Apr 18 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0f4366ae4a82c833071ef05f4bc72503119c0af commit f0f4366ae4a82c833071ef05f4bc72503119c0af Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Apr 19 20:31:46 2017 [MD settings] observe changes to default font size in Appearance This CL updates the fixed font size from the Appearance section reliably. (It was previously working depending on which settings page had been visited). Also, updates the UI to remove the font size on the example of the fixed font size. BUG= 671562 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817243003 Cr-Commit-Position: refs/heads/master@{#465054} (cherry picked from commit b7cd6a5130a7a261ae997c5e37dc4fec4560cff3) Review-Url: https://codereview.chromium.org/2830883002 . Cr-Commit-Position: refs/branch-heads/3071@{#64} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/f0f4366ae4a82c833071ef05f4bc72503119c0af/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html [modify] https://crrev.com/f0f4366ae4a82c833071ef05f4bc72503119c0af/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js [modify] https://crrev.com/f0f4366ae4a82c833071ef05f4bc72503119c0af/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/f0f4366ae4a82c833071ef05f4bc72503119c0af/chrome/browser/resources/settings/appearance_page/appearance_page.js
,
Apr 20 2017
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12.4 using chrome latest Dev #59.0.3071.15 by following steps mentioned in the original comment. Observed the page source font size changes according to the default font size as expected. Hence adding TE-Verified label. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jshan...@etouch.net
, Dec 6 2016