New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671547 link

Starred by 3 users
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Dec 2016
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Content of 'chrome://md-settings/content/all' is not visible.

Reported by jshan...@etouch.net, Dec 6 2016 
Chrome Version : 57.0.2943.0 (Official Build) (32-bit)d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba-refs/heads/master@{#436483}-32/64 bit
OS: Windows(7,8,8.1,10),Mac OS X(10.11.6, 10.12.1), Linux (14.04 LTS)

Pre-condition: Enable Site settings with All sites and Site details from chrome://flags

Steps: 
1. Launch Chrome and navigate to chrome://md-settings/content/all
2. Observe

Actual: Content of All sites is not visible 

Expected: Content of All sites is should be visible properly

This is a regression issue broken in 'M57' and below is the manual regression range:

Good Build: 57.0.2942.0
Bad Build:  57.0.2943.0
Actual_result.jpg
74.4 KB View Download
Expected_result.jpg
92.5 KB View Download

Comment 1 by hdodda@chromium.org, Dec 6 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: dullweber@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 57.0.2942.0 (Revision : 436203)
Bad Build:  57.0.2943.0 (Revision : 436483)

You are probably looking for a change made after 436290 (known good), but no later than 436291 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/5963832e58b386492b76ef530831f4704ac13cb2..d59c57610403a5ae1b1f3f7a0af323ba53ff0a01

From the CL above, assigning the issue to the concern owner 

@dullweber - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2525943002

Thanks!

Comment 2 by dullweber@chromium.org, Dec 6 2016

Status: Started (was: Assigned)
That looks like it's caused by me. Will send out a fix in a few minutes!

Comment 3 by dullweber@chromium.org, Dec 6 2016 

I failed to reproduce it with the current master on linux, with revision 1d07eb9 and also the canary build 2943 on mac. Do you have anything special in your test environment? Could you try to reproduce it again and see if it still doesn't work?

Chromium	57.0.2943.0 (Developer Build) (64-bit)
Revision	1d07eb9cf0934012a3af96cb7e5e1bdee8de2779
OS		Linux

Comment 4 by hdodda@chromium.org, Dec 14 2016 

Issue is still reproduced on mac os 10.11.6 and windows 10 using chrome latest canary M57 #57.0.2951.0 & #57.0.2950.0 .

Thanks!

Comment 5 by dullweber@chromium.org, Dec 15 2016 

Thanks. I found the issue: only exceptions from chrome apps are displayed incorrectly.

Here is the CL for it https://codereview.chromium.org/2577043002/
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f0c6183d9cdbad6ec74a55dae7d855a5860791

commit 83f0c6183d9cdbad6ec74a55dae7d855a5860791
Author: dullweber <dullweber@chromium.org>
Date: Tue Dec 20 09:11:54 2016

Fix content settings for hosted apps not displayed correctly after change from http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have a displayName to be consistent with the other exception objects.

BUG= 671547 

Review-Url: https://codereview.chromium.org/2577043002
Cr-Commit-Position: refs/heads/master@{#439757}

[modify] https://crrev.com/83f0c6183d9cdbad6ec74a55dae7d855a5860791/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/83f0c6183d9cdbad6ec74a55dae7d855a5860791/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/83f0c6183d9cdbad6ec74a55dae7d855a5860791/chrome/browser/ui/webui/site_settings_helper_unittest.cc

Comment 7 by dullweber@chromium.org, Dec 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment