Issue metadata
Sign in to add a comment
|
Nested SVG clip-path not considered if empty
Reported by
uhadamae...@googlemail.com,
Dec 6 2016
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.59 Safari/537.36 Example URL: https://jsfiddle.net/rw5m7fym/ Steps to reproduce the problem: 1. Use a clip-path, that references another clip-Path, like in the following URL: https://jsfiddle.net/rw5m7fym/ 2. The clipping is not applied at all, but with Chrome 54 it was applied (white screen was left over previously, but now a red path is visible) 3. if the referenced Clip-path has a stroke assigned, it works as expected, like in this example: https://jsfiddle.net/1jxxgey5/ What is the expected behavior? The Clipping should be applied. In my example JsFiddle, nothing should be visible anymore (white screen). What went wrong? The Clipping is only applied, if a stroke is set. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes 54 Does this work in other browsers? Yes Chrome version: 55.0.2883.75 m Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 I hope this is not a duplicate of Issue 659790 , but I think it's not when looking at the Chrome Versions where it worked/didn't work
,
Dec 6 2016
,
Dec 6 2016
You are probably looking for a change made after 418383 (known good), but no later than 418388 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/ef7ea66559beeb199cf68701768956cf4b62a5f2..9cb8fb393e8af43e4961d3aaff549138508d0966 Most likely https://codereview.chromium.org/2322343003?
,
Dec 6 2016
Jupp. I have a CL in testing.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bfec8883cac1e879727b3f95ae6de1b19146473 commit 4bfec8883cac1e879727b3f95ae6de1b19146473 Author: fs <fs@opera.com> Date: Tue Dec 06 16:01:43 2016 Don't fail clip-paths with empty bounds An empty nested clip-path should result in an empty clip-path (clipping away everything.) BUG= 671543 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2555483003 Cr-Commit-Position: refs/heads/master@{#436605} [modify] https://crrev.com/4bfec8883cac1e879727b3f95ae6de1b19146473/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/4bfec8883cac1e879727b3f95ae6de1b19146473/third_party/WebKit/LayoutTests/svg/clip-path/nested-empty-clip-expected.html [add] https://crrev.com/4bfec8883cac1e879727b3f95ae6de1b19146473/third_party/WebKit/LayoutTests/svg/clip-path/nested-empty-clip.html [modify] https://crrev.com/4bfec8883cac1e879727b3f95ae6de1b19146473/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp
,
Dec 6 2016
,
Dec 7 2016
,
Dec 7 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26e44a294ddacf179061579505c4b5f6c6d4aa1d commit 26e44a294ddacf179061579505c4b5f6c6d4aa1d Author: Fredrik Söderquist <fs@opera.com> Date: Wed Dec 07 15:56:41 2016 Don't fail clip-paths with empty bounds An empty nested clip-path should result in an empty clip-path (clipping away everything.) BUG= 671543 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2555483003 Cr-Commit-Position: refs/heads/master@{#436605} (cherry picked from commit 4bfec8883cac1e879727b3f95ae6de1b19146473) Review URL: https://codereview.chromium.org/2560843002 . Cr-Commit-Position: refs/branch-heads/2924@{#379} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/26e44a294ddacf179061579505c4b5f6c6d4aa1d/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/26e44a294ddacf179061579505c4b5f6c6d4aa1d/third_party/WebKit/LayoutTests/svg/clip-path/nested-empty-clip-expected.html [add] https://crrev.com/26e44a294ddacf179061579505c4b5f6c6d4aa1d/third_party/WebKit/LayoutTests/svg/clip-path/nested-empty-clip.html [modify] https://crrev.com/26e44a294ddacf179061579505c4b5f6c6d4aa1d/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp
,
Dec 8 2016
Verified the issue on windows 10, Mac 10.12.1 and Ubuntu 14.04 using chrome dev version #56.0.2924.21 as per comment #0 Observed that nothing was visible anymore i.e only white screen appeared after navigating to the URL: https://jsfiddle.net/rw5m7fym/. Hence, the fix is working as expected. Attaching screen cast for reference. Hence, adding the verified labels. Thanks...!! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by f...@opera.com
, Dec 6 2016Labels: -OS-Windows -Type-Compat Type-Bug-Regression
Status: Available (was: Unconfirmed)
Summary: Nested SVG clip-cath not considered if empty (was: SVG Clip-Path not considered)