File selection and deletion makes the UI slow in a DCIM folder |
|||||||
Issue descriptionChrome OS Version: ToT Steps To Reproduce: (1) Prepare an SD card or USB memory with many (~100+) image files in "/DCIM" folder (2) Insert the SD card to the device. The DCIM folder opens in Files app. (3) Try to choose all the photo by pressing [shift] and hitting [downarrow] key multiple times (by auto repeat of the keyboard). Expected Result: It runs scan (for cloud import) for the chosen files. Actual Result: It runs "fixed file set" scan for the files every time a new file is selected. As a result, the UI slows down as the number of selected files increase. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? This may make the UI slow in some cases. Additionally, delete operation of many files after selection can be also slow (unless the user closes the foreground UI), as the scan is also triggered every time the selected file list is updated. This issue will be mitigated when crbug.com/668574 is resolved.
,
Dec 19 2016
,
Dec 19 2016
,
Dec 19 2016
> This issue will be mitigated when crbug.com/668574 is resolved. The issue still exists as long as the scan time increases in a linear proportion to the number of files. Instead we can use CHANGE_THROTTLED mode in EventType. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/file_selection.js?l=154
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/875523b8779972b83b1a6f6d82b649e6c15866e8 commit 875523b8779972b83b1a6f6d82b649e6c15866e8 Author: yamaguchi <yamaguchi@chromium.org> Date: Tue Dec 20 04:17:03 2016 Avoid UI jankiness caused by triggering selection scan too frequently. BUG= 671517 TEST=manual test by the repro step noted in the bug CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2589823002 Cr-Commit-Position: refs/heads/master@{#439702} [modify] https://crrev.com/875523b8779972b83b1a6f6d82b649e6c15866e8/ui/file_manager/file_manager/foreground/js/import_controller.js
,
Dec 20 2016
,
Mar 4 2017
,
Apr 17 2017
,
May 9 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yamaguchi@chromium.org
, Dec 6 2016