New issue
Advanced search Search tips

Issue 671516 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove the --enable-apps-show-on-first-paint flag

Project Member Reported by benwells@chromium.org, Dec 6 2016

Issue description

This feature is either released and should have the disable option removed, or is never going to be released. I think it's the latter.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387b7142c3f6124c45afcceb60349479748d3c63

commit 387b7142c3f6124c45afcceb60349479748d3c63
Author: jam <jam@chromium.org>
Date: Wed Dec 07 15:48:31 2016

Remove code to defer app window appearance until first paint.

This is effectively dead code since no one has worked to turn it on for two and a half years and chrome apps are deprecated.

The current motivation is fixing PlatformAppBrowserTest.ActiveAppsAreRecorded with PlzNavigate, since the changes in r275132 made it not work with it (the test event comes too early with PlzNavigate). Instead of fixing this, I decided it's simpler to remove this code.

BUG= 225843 , 504347 , 671516 

Review-Url: https://codereview.chromium.org/2553263002
Cr-Commit-Position: refs/heads/master@{#436964}

[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/chrome/app/generated_resources.grd
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/chrome/browser/about_flags.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/chrome/browser/extensions/api/tabs/ash_panel_contents.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/chrome/browser/extensions/api/tabs/ash_panel_contents.h
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/chrome/test/data/extensions/platform_apps/active_test/test.js
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/api/app_window/app_window_api.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/app_window/app_window_contents.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/app_window/app_window_contents.h
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/app_window/test_app_window_contents.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/browser/app_window/test_app_window_contents.h
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/common/api/app_current_window_internal.idl
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/common/api/app_window.idl
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/common/switches.cc
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/common/switches.h
[modify] https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63/extensions/renderer/resources/app_window_custom_bindings.js

Comment 2 by jam@chromium.org, Dec 7 2016

Owner: jam@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment