Media files produced by Android apps are saved in Android internal storage, isolated from Chrome OS user storage. This bug is about adding a feature to make them accessible from Chrome OS Files.app. Design doc: go/arc++mediaview
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c216c500aceb0054b09365f914187594b4bcd7c5 commit c216c500aceb0054b09365f914187594b4bcd7c5 Author: nya <nya@chromium.org> Date: Fri Dec 09 10:21:20 2016 ARC Media View: Mojo definitions. BUG= chromium:671511 TEST=trybot Review-Url: https://codereview.chromium.org/2559643002 Cr-Commit-Position: refs/heads/master@{#437511} [modify] https://crrev.com/c216c500aceb0054b09365f914187594b4bcd7c5/components/arc/common/file_system.mojom [modify] https://crrev.com/c216c500aceb0054b09365f914187594b4bcd7c5/components/arc/test/fake_file_system_instance.cc [modify] https://crrev.com/c216c500aceb0054b09365f914187594b4bcd7c5/components/arc/test/fake_file_system_instance.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5df1e3fe0001e776729dafe7be76ad9f8096868 commit f5df1e3fe0001e776729dafe7be76ad9f8096868 Author: nya <nya@chromium.org> Date: Wed Dec 14 04:36:17 2016 mediaview: Skeleton of ARC Documents Provider FS. This patch will add a skelton of ARC Documents Provider File System which will allow Chrome to access Android Documents Provider in ARC. It almost contains boilerplates only; implementations are coming in later patches. BUG= chromium:671511 TEST=trybot Review-Url: https://codereview.chromium.org/2568033002 Cr-Commit-Position: refs/heads/master@{#438431} [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc [add] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.h [add] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.cc [add] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.h [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/fileapi/file_system_backend.cc [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/fileapi/file_system_backend.h [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/chrome/browser/platform_util_unittest.cc [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/storage/browser/fileapi/file_system_context.cc [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/storage/common/fileapi/file_system_types.h [modify] https://crrev.com/f5df1e3fe0001e776729dafe7be76ad9f8096868/storage/common/fileapi/file_system_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29942ba33818a9db2fc90a441b80d56cbdbc1f1f commit 29942ba33818a9db2fc90a441b80d56cbdbc1f1f Author: nya <nya@chromium.org> Date: Fri Dec 16 11:53:20 2016 mediaview: Introduce ArcDocumentsProviderRoot. On file system operations, ArcDocumentsProviderAsyncFileUtil will look up a corresponding ArcDocumentsProviderRoot instance from ArcDocumentsProviderRootMap and delegates operations to it. ArcDocumentsProviderRootMap is owned by ArcDocumentsProviderBackendDelegate because the delegate will also use the root map to implement its methods soon. BUG= chromium:671511 TEST=unit_tests --gtest_filter='Arc*' TEST=trybot Review-Url: https://codereview.chromium.org/2572683004 Cr-Commit-Position: refs/heads/master@{#439090} [modify] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc [modify] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.h [modify] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.cc [modify] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.h [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_map.cc [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_map.h [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h [add] https://crrev.com/29942ba33818a9db2fc90a441b80d56cbdbc1f1f/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/787e1c859432963c8efe3525a7ad1cc340fa66a5 commit 787e1c859432963c8efe3525a7ad1cc340fa66a5 Author: nya <nya@chromium.org> Date: Wed Dec 21 04:50:36 2016 mediaview: Implement ArcDocumentsProviderRoot. BUG= chromium:671511 TEST=unit_tests --gtest_filter='Arc*' TEST=trybot Review-Url: https://codereview.chromium.org/2574173002 Cr-Commit-Position: refs/heads/master@{#440020} [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h [add] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc [modify] https://crrev.com/787e1c859432963c8efe3525a7ad1cc340fa66a5/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec0ad68ca0447e40e6a2396ed5742d009c23641c commit ec0ad68ca0447e40e6a2396ed5742d009c23641c Author: nya <nya@chromium.org> Date: Fri Jan 06 06:30:59 2017 mediaview: Implement ArcDocumentsProviderBackendDelegate. BUG= chromium:671511 TEST=unit_tests --gtest_filter='Arc*' TEST=trybot Review-Url: https://codereview.chromium.org/2580713004 Cr-Commit-Position: refs/heads/master@{#441891} [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.cc [add] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_file_stream_reader.cc [add] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_file_stream_reader.h [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h [modify] https://crrev.com/ec0ad68ca0447e40e6a2396ed5742d009c23641c/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3022c4f86fd02985e11e524e951512c85c4f4268 commit 3022c4f86fd02985e11e524e951512c85c4f4268 Author: nya <nya@chromium.org> Date: Fri Jan 06 09:04:18 2017 mediaview: Register ARC documents provider file system. ArcContentFileSystemService is renamed to ArcFileSystemService, and it will register two ARC file systems. Also constants in arc_content_file_system_url_util.h are renamed now that we have two ARC file systems. BUG= chromium:671511 TEST=unit_tests --gtest_filter='Arc*' TEST=trybot Review-Url: https://codereview.chromium.org/2589643002 Cr-Commit-Position: refs/heads/master@{#441905} [modify] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/arc_service_launcher.cc [modify] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc [delete] https://crrev.com/8e9a8aabbde296324fa081995177dd5aac5622e4/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_service.cc [delete] https://crrev.com/8e9a8aabbde296324fa081995177dd5aac5622e4/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_service.h [modify] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc [modify] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.h [modify] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util_unittest.cc [add] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.cc [add] https://crrev.com/3022c4f86fd02985e11e524e951512c85c4f4268/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3c37251cda5e7e0f8679de7c0d8df4df1709fad commit c3c37251cda5e7e0f8679de7c0d8df4df1709fad Author: nya <nya@chromium.org> Date: Sat Jan 07 00:42:29 2017 media view: Add strings for media views. BUG= chromium:671511 TEST=trybot Review-Url: https://codereview.chromium.org/2616023006 Cr-Commit-Position: refs/heads/master@{#442113} [modify] https://crrev.com/c3c37251cda5e7e0f8679de7c0d8df4df1709fad/chrome/app/chromeos_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6 commit 4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6 Author: nya <nya@chromium.org> Date: Thu Jan 12 10:57:26 2017 mediaview: Mount ARC documents provider file system volumes. New media view volumes are added to chromeos::VolumeManager so that they are available to Files.app. UI patches are coming later, so at this point it looks like unusable unknown volumes appear in Files.app. To hide them from users for now, the feature is guarded with base::FeatureList. Once UI is ready I will make them enabled by default. BUG= chromium:671511 TEST=New (unusable) volumes are shown with --enable-features=ArcMediaView TEST=Media views work with local pending UI patches Review-Url: https://codereview.chromium.org/2580303002 Cr-Commit-Position: refs/heads/master@{#443205} [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.cc [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h [add] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_media_view_util.cc [add] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/arc/fileapi/arc_media_view_util.h [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/file_manager/volume_manager.h [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/browser/chromeos/fileapi/file_system_backend.cc [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/components/arc/BUILD.gn [add] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/components/arc/file_system/arc_file_system_observer.h [modify] https://crrev.com/4b8fa62ab223d4db0ea5d1a8359cbaeba3d757a6/third_party/closure_compiler/externs/file_manager_private.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35eb49f18a29eb0ad82faf79cf865c5ba03926a8 commit 35eb49f18a29eb0ad82faf79cf865c5ba03926a8 Author: nya <nya@chromium.org> Date: Mon Jan 16 03:48:22 2017 mediaview: Implement UI. Media view roots are added to Files.app. They appear just above "Add new services" button. BUG= chromium:671511 TEST=Media view works on samus with --enable-features=ArcMediaView CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2622133008 Cr-Commit-Position: refs/heads/master@{#443840} [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/background/js/volume_info_list_impl.js [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/background/js/volume_manager_impl.js [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/background/js/volume_manager_util.js [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/common/js/util.js [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/common/js/volume_manager_common.js [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/css/file_types.css [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/2x/audio.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/2x/audio_active.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/2x/images.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/2x/images_active.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/2x/videos.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/2x/videos_active.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/audio.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/audio_active.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/images.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/images_active.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/videos.png [add] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/images/volumes/videos_active.png [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/js/quick_view_uma.js [modify] https://crrev.com/35eb49f18a29eb0ad82faf79cf865c5ba03926a8/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d266375ae1ebcd12933e946a1ce455fbec9b7b6 commit 6d266375ae1ebcd12933e946a1ce455fbec9b7b6 Author: nya <nya@chromium.org> Date: Mon Jan 16 07:42:46 2017 mediaview: Enable by default. Now all required changes are in. Let us enable the feature by default. BUG= chromium:671511 TEST=Media view works on samus without flags Review-Url: https://codereview.chromium.org/2638713002 Cr-Commit-Position: refs/heads/master@{#443855} [modify] https://crrev.com/6d266375ae1ebcd12933e946a1ce455fbec9b7b6/chrome/browser/chromeos/arc/fileapi/arc_media_view_util.cc
Implementation done!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eff8ce80aa2744b1e0fc8ca69d1186d32c420655 commit eff8ce80aa2744b1e0fc8ca69d1186d32c420655 Author: pkalinnikov <pkalinnikov@chromium.org> Date: Mon Jan 16 14:11:32 2017 Revert of mediaview: Enable by default. (patchset #1 id:1 of https://codereview.chromium.org/2638713002/ ) Reason for revert: ArcSessionManagerTest.ConsumerAccount and 3 more ArcSessionManagerTest.* tests are failing on "Linux Chromium OS ASan LSan Tests (1)" builder. Original issue's description: > mediaview: Enable by default. > > Now all required changes are in. Let us enable the feature by > default. > > BUG= chromium:671511 > TEST=Media view works on samus without flags > > Review-Url: https://codereview.chromium.org/2638713002 > Cr-Commit-Position: refs/heads/master@{#443855} > Committed: https://chromium.googlesource.com/chromium/src/+/6d266375ae1ebcd12933e946a1ce455fbec9b7b6 TBR=hidehiko@chromium.org,nya@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:671511 Review-Url: https://codereview.chromium.org/2635943002 Cr-Commit-Position: refs/heads/master@{#443888} [modify] https://crrev.com/eff8ce80aa2744b1e0fc8ca69d1186d32c420655/chrome/browser/chromeos/arc/fileapi/arc_media_view_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/956c03968aee8c6d45c52a1d237f857fe4e133a3 commit 956c03968aee8c6d45c52a1d237f857fe4e133a3 Author: nya <nya@chromium.org> Date: Tue Jan 17 08:06:39 2017 Reland of mediaview: Enable by default. (patchset #1 id:1 of https://codereview.chromium.org/2635943002/ ) Reason for revert: The issue has been resolved in crrev.com/2639483003. Original issue's description: > Revert of mediaview: Enable by default. (patchset #1 id:1 of https://codereview.chromium.org/2638713002/ ) > > Reason for revert: > ArcSessionManagerTest.ConsumerAccount and 3 more ArcSessionManagerTest.* tests are failing on "Linux Chromium OS ASan LSan Tests (1)" builder. > > Original issue's description: > > mediaview: Enable by default. > > > > Now all required changes are in. Let us enable the feature by > > default. > > > > BUG= chromium:671511 > > TEST=Media view works on samus without flags > > > > Review-Url: https://codereview.chromium.org/2638713002 > > Cr-Commit-Position: refs/heads/master@{#443855} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d266375ae1ebcd12933e946a1ce455fbec9b7b6 > > TBR=hidehiko@chromium.org,nya@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= chromium:671511 > > Review-Url: https://codereview.chromium.org/2635943002 > Cr-Commit-Position: refs/heads/master@{#443888} > Committed: https://chromium.googlesource.com/chromium/src/+/eff8ce80aa2744b1e0fc8ca69d1186d32c420655 BUG= chromium:671511 TEST=browser_tests --gtest_filter='ArcSessionManagerTest.*' # with ASAN Review-Url: https://codereview.chromium.org/2630283003 Cr-Commit-Position: refs/heads/master@{#444001} [modify] https://crrev.com/956c03968aee8c6d45c52a1d237f857fe4e133a3/chrome/browser/chromeos/arc/fileapi/arc_media_view_util.cc
Done again :)
Here is a visual of the agreed changes for reference.
Comment 1 by bugdroid1@chromium.org
, Dec 9 2016