Issue metadata
Sign in to add a comment
|
DevTools: [Performance] bottom-up profiler expanding is broken |
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2943.0 OS Version: URLs (if applicable) : What steps will reproduce the problem? 1. Record a timeline. 2. Select region 3. Select "bottom-up", try to expand See screenshot. Notice how the "Common.ContentProvider.performSearchInContent" is expanded, but no children are shown. No errors in console. Attaching timeline to be comprehensive.
,
Dec 6 2016
looks like a recent regression.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/273f0908bb5fe23363e686201ac0e6c86d0601a7 commit 273f0908bb5fe23363e686201ac0e6c86d0601a7 Author: alph <alph@chromium.org> Date: Tue Dec 06 19:06:57 2016 Revert of [Devtools] Fixed flakey network-columns-sorted.html test (patchset #1 id:1 of https://codereview.chromium.org/2542553002/ ) Reason for revert: Broke timeline tree view. BUG= 671487 Original issue's description: > [Devtools] Fixed flakey network-columns-sorted.html test > > Fixes recently added flakey test. > > R=dgozman,lushnikov > BUG= 669753 > > Committed: https://crrev.com/82ef6cfd810f4acb06a7aafc598fefc806773b12 > Cr-Commit-Position: refs/heads/master@{#435391} TBR=dgozman@chromium.org,lushnikov@chromium.org,allada@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 669753 NOTRY=true Review-Url: https://codereview.chromium.org/2554093003 Cr-Commit-Position: refs/heads/master@{#436674} [modify] https://crrev.com/273f0908bb5fe23363e686201ac0e6c86d0601a7/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted-expected.txt [modify] https://crrev.com/273f0908bb5fe23363e686201ac0e6c86d0601a7/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c2f9ee53faefc6bfd70834df9cfb794412eb425 commit 6c2f9ee53faefc6bfd70834df9cfb794412eb425 Author: alph <alph@chromium.org> Date: Tue Dec 06 23:21:01 2016 Revert of [Devtools] Moved flatten children to children nodes instead of datagrid (patchset #4 id:100001 of https://codereview.chromium.org/2540543002/ ) Reason for revert: Broke timeline tree view. BUG= 671487 Original issue's description: > [Devtools] Moved flatten children to children nodes instead of datagrid > > This patch moves the flattenNodeList() and renames it flattenChildren() to > be more appropriate. It is also moves it to the nodes instead of the > DataGrid. > > R=dgozman > BUG=None > > Committed: https://crrev.com/9d0774bc242a8126f10c9be7922549336162ed88 > Cr-Commit-Position: refs/heads/master@{#434901} TBR=dgozman@chromium.org,allada@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.chromium.org/2554753004 Cr-Commit-Position: refs/heads/master@{#436770} [delete] https://crrev.com/ab650bf37d14c76a794fe42f7cd0739dc01b752a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted-expected.txt [delete] https://crrev.com/ab650bf37d14c76a794fe42f7cd0739dc01b752a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html [modify] https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425/third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid-expected.txt [modify] https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425/third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid.html [modify] https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js [modify] https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425/third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js [modify] https://crrev.com/6c2f9ee53faefc6bfd70834df9cfb794412eb425/third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js
,
Dec 6 2016
,
Dec 7 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lushnikov@chromium.org
, Dec 6 2016