New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671483 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Move "Cast..." macOS menu bar item from File to View

Project Member Reported by taku...@chromium.org, Dec 6 2016

Issue description

As per the discussion in the relevant UI email thread, we should move the menu item to under "View".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db72fe0effc167be825c9243ca986c2da67d1aa3

commit db72fe0effc167be825c9243ca986c2da67d1aa3
Author: takumif <takumif@chromium.org>
Date: Fri Dec 09 19:47:42 2016

Move the "Cast..." menu item in macOS menu bar from File to View

Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item
to the View section. It will be placed after "Zoom Out" and before "Developer."
It will also have separators before and after it.

BUG= 671483 

Review-Url: https://codereview.chromium.org/2554753002
Cr-Commit-Position: refs/heads/master@{#437610}

[modify] https://crrev.com/db72fe0effc167be825c9243ca986c2da67d1aa3/chrome/app/nibs/MainMenu.xib

Status: Fixed (was: Assigned)
Labels: Merge-Request-56
I'd like to request a merge of #1 to M56. I've verified the fix in Mac Canary.

Comment 4 by dimu@chromium.org, Dec 13 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Cc: apaci...@chromium.org
Jennifer, could you help me merge this to M56? Thanks!
I'll merge the change this afternoon.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c57af395d8c974442b16db4252a0e468b2d6119

commit 5c57af395d8c974442b16db4252a0e468b2d6119
Author: Jennifer Apacible <apacible@chromium.org>
Date: Tue Dec 13 22:57:47 2016

Move the "Cast..." menu item in macOS menu bar from File to View

Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item
to the View section. It will be placed after "Zoom Out" and before "Developer."
It will also have separators before and after it.

BUG= 671483 

Review-Url: https://codereview.chromium.org/2554753002
Cr-Commit-Position: refs/heads/master@{#437610}
(cherry picked from commit db72fe0effc167be825c9243ca986c2da67d1aa3)

Review URL: https://codereview.chromium.org/2575633002 .

Cr-Commit-Position: refs/branch-heads/2924@{#477}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/5c57af395d8c974442b16db4252a0e468b2d6119/chrome/app/nibs/MainMenu.xib

Sign in to add a comment