New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671479 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ lushnikov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: [memory leak] GlobalObjectCleared event is not called for workers

Project Member Reported by lushnikov@chromium.org, Dec 6 2016 
Chrome Version       : 57.0.2943.0

A lot of systems in DevTools rely on GlobalObjectCleared event to do a cleanup.

The event, however, is not called for workers. As a result, a lot things get leaked.

Comment 1 by kozyatinskiy@chromium.org, Dec 6 2016

Labels: Hotlist-Polish

Comment 2 by kozyatinskiy@chromium.org, Dec 7 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2554093004/
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/422ebff9ec33ed3a9219810ba899d7e33799d743

commit 422ebff9ec33ed3a9219810ba899d7e33799d743
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Dec 07 05:32:57 2016

[DevTools] proper cleanup BlackboxManager on targetRemoved

BUG= chromium:671479 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2554093004
Cr-Commit-Position: refs/heads/master@{#436871}

[modify] https://crrev.com/422ebff9ec33ed3a9219810ba899d7e33799d743/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Comment 4 by kozyatinskiy@chromium.org, Dec 7 2016

Status: Fixed (was: Started)
I checked that in other places we correctly cleanup related data on targetRemoved.
►

Sign in to add a comment