Android L builder failing due to MediaDevices.ondevicechange not found |
||||||
Issue descriptionLooks like this CL https://codereview.chromium.org/2547563002 added this method to the list of enabled methods for WebKit, but it notes that Android is not supported due to SystemMonitor not supported on that platform. So the test should not assume that this method should be enabled on Android. I suppose the fix is to add it to android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
,
Dec 6 2016
,
Dec 6 2016
,
Dec 6 2016
+guido Do the Android (non webview) bots fail? If not, maybe the Linux virtual expected.txt takes care of it or we don't run Android tests on the bots? If it's only WebView, your fix suggestion should work. The link to the bot, for posterity: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20(dbg)/builds/21099 Also, I don't think this should be a RVG bug :)
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c76896ad46b39cb0773f2e197302ef98f271032 commit 8c76896ad46b39cb0773f2e197302ef98f271032 Author: aluo <aluo@chromium.org> Date: Tue Dec 06 16:05:59 2016 Remove MediaDevices.onondevicechange from WebView stable interfaces BUG= 671461 Review-Url: https://codereview.chromium.org/2556583003 Cr-Commit-Position: refs/heads/master@{#436607} [modify] https://crrev.com/8c76896ad46b39cb0773f2e197302ef98f271032/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
,
Dec 6 2016
,
Dec 6 2016
,
Dec 7 2016
The attribute is visible on Linux, but not on Android and WebView. The android bots don't fail. I guess they run tests in test mode where the attribute is visible. Either way, the fix solves it. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by aluo@chromium.org
, Dec 6 2016