New issue
Advanced search Search tips

Issue 671454 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PolicyUITest.SendPolicyValues" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 6 2016 
"PolicyUITest.SendPolicyValues" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKAsSBUZsYWtlIh1Qb2xpY3lVSVRlc3QuU2VuZFBvbGljeVZhbHVlcww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by rogerta@chromium.org, Dec 6 2016 

Error call stack:

[1:1:1205/163201.710647:FATAL:DrawingRecorder.cpp(88)] Check failed: 0 == picture->approximateOpCount() (0 vs. 144)"LayoutTable TABLE"
#0 0x000002bc9e0e base::debug::StackTrace::StackTrace()
#1 0x000002be2a0b logging::LogMessage::~LogMessage()
#2 0x0000056283bd blink::DrawingRecorder::~DrawingRecorder()
#3 0x00000643138a blink::TablePainter::paintCollapsedBorders()
#4 0x000006430ec8 blink::TablePainter::paintObject()
#5 0x00000625c89d blink::LayoutTable::paintObject()
#6 0x0000063cb7c8 blink::BlockPainter::paint()
#7 0x00000619279d blink::LayoutBlock::paint()
#8 0x0000063cc05c blink::BlockPainter::paintChildren()
#9 0x0000061927ad blink::LayoutBlock::paintChildren()
...

I have seen this happen for other steps too, so I don't believe this is realted to PolicyUITests:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/350249/steps/telemetry_perf_unittests%20%28with%20patch%29/logs/stdio

(Search for DrawingRecorder)

Comment 2 by rogerta@chromium.org, Dec 6 2016

Labels: -Sheriff-Chromium
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
From the revision log of DrawingRecorder.cpp, seems like changes were landed and reverted several times recently:

https://chromium.googlesource.com/chromium/src/+log/master/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

wangxianzhu: seems like there is still a problem though.  Some flakiness.  Can you please take a look?  Thanks.

Comment 3 by wangxianzhu@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)
It's now passing:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_browser_tests (with patch)&tests=PolicyUITest.SendPolicyValues

The relanding is after a revert of another conflicting CL, so it is good.
►

Sign in to add a comment