New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671427 link

Starred by 1 user
Status: Fixed
Owner:
braveyao@chromium.org
Closed: Jun 2017
Cc:
█ kavvaru@chromium.org
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

OSX: there is no ScreenCaptureNotificationBar under some senarios with an external monitor connected

Project Member Reported by braveyao@chromium.org, Dec 6 2016 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) connect an external monitor to a MBP (mine is OSX 10.12 + Retina)
(2) open a chrome tab on the external monitor
(3) start tab capturing to that tab

What is the expected result?
capturing starts with the notification bar for stopping sharing

What happens instead?
there is no such bar on any of the monitors

Please use labels and text to provide additional information.
If to share a tab on the built-in monitor, the notification bar will show up on the primary monitor.

Results of other combinations:
Window picker on primary monitor, there is no notification bar only if doing tab capture to the tab on external monitor. Other cases all work.
Window picker on external monitor, there in notification bar only if doing tab capture to the tab on primary monitor. Other cases all don't work.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47c94aa794bdf214c040ad45de59384a745186fa

commit 47c94aa794bdf214c040ad45de59384a745186fa
Author: braveyao <braveyao@chromium.org>
Date: Fri Jun 23 16:25:17 2017

Desktop_capture: fix the missing notificationbar on OSX

The problem only happens when an external monitor is connected to a MBP
and works together with the built-in screen. If the desktop capture is
started from the external monitor, e.g. window picker locates on the
external monitor, there is no notification bar on any screen. There is
no such problem when desktop capture is started from built-in screen.

The problem is because chrome aligns the notificaiton bar to the
cooridnates of the external monitor, but still draw it to the built-in
screen.

The fix is to draw the notification bar to the screen from which the
desktop capture is started, by adding the offset of x coordinat of the
curren |mainScreen|.

Bug:  671427 
Change-Id: Ida11c91cc0525dc14110f42662c9f3269bf09234
Reviewed-on: https://chromium-review.googlesource.com/545115
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481916}
[modify] https://crrev.com/47c94aa794bdf214c040ad45de59384a745186fa/chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm

Comment 2 by braveyao@chromium.org, Jun 23 2017

Status: Fixed (was: Assigned)

Comment 3 by kavvaru@chromium.org, Jun 27 2017

Cc: kavvaru@chromium.org
Labels: Needs-Feedback
Tested the issue on Mac 10.12.5 Retina using chrome version 61.0.3141.0 with the below steps

1.connect an external monitor to a MBP
2.open a chrome tab on the external monitor
3.start tab capturing to that tab (Ex:: screencastify tab capture)
4.able to see the notification bar at bottom of tab

Please find the attached screen shot and confirm on the behaviour as seen the same behaviour on version 61.0.3138.0 before the fix.
Please suggest to verify the issue from our end.

Thanks,
671427.png
349 KB View Download

Comment 4 by braveyao@chromium.org, Jun 27 2017 

Tested with Canary 61.3142 on MBP and the notification bar can be shown for tab capture as well as screen/window capture.

I have not idea about screencastify(Tried and saw its own notification bar only ,but not the chrome one). I suppose you can test with Hangout/Meet.

PS: I just noticed that with tab capture, the notification bar will follow the tab but not the window picker. Not sure if this is WAI. Whatever the screen/window capture and tab capture run in two different code path, which may imply some differences.
►

Sign in to add a comment