New issue
Advanced search Search tips

Issue 671419 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Jan 2017
Cc:
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Create scroll nodes for layout objects that have main thread scrolling reasons

Project Member Reported by pdr@chromium.org, Dec 6 2016 
We need to ensure that scroll nodes are created anytime an object has main thread scrolling reasons. In other words, we need to remove the optimization that scroll nodes are only created if an object actually scrolls.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/132d9363bf25b5f64df16d35aa8515c8ae0b9e90

commit 132d9363bf25b5f64df16d35aa8515c8ae0b9e90
Author: pdr <pdr@chromium.org>
Date: Wed Dec 07 02:05:27 2016

Create scroll properties for main thread scrolling even w/o scrolling

If an object with overflow scrolling does not actually scroll, we would not
create a scroll paint property node before this patch. This was wrong because
a paint property node may be needed for main thread scrolling reasons.

BUG= 671419 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2553093003
Cr-Commit-Position: refs/heads/master@{#436833}

[modify] https://crrev.com/132d9363bf25b5f64df16d35aa8515c8ae0b9e90/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/132d9363bf25b5f64df16d35aa8515c8ae0b9e90/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Comment 2 by pdr@chromium.org, Jan 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment