New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671408 link

Starred by 5 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 669964



Sign in to add a comment

Fully implement ScreenMus

Project Member Reported by sky@chromium.org, Dec 5 2016

Issue description

ScreenMus either needs to merge with ScreenAsh or implement the remaining NOTIMPLEMENTED functions in ScreenBase.
 

Comment 1 by sky@chromium.org, Feb 15 2017

This refers to the ScreenMus in ash, not the views one.

Comment 2 by sky@chromium.org, Feb 28 2017

Labels: -Pri-3 mustash-1 Proj-Mustash-Mash Pri-1
Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
Here's what is left: IsWindowUnderCursor() and GetWindowAtScreenPoint().
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860df320f00a381f2a743d14a7fc095130428255

commit 860df320f00a381f2a743d14a7fc095130428255
Author: erg <erg@chromium.org>
Date: Thu Mar 02 00:16:17 2017

mus+ash: Copy parts of ScreenAsh to ScreenMus.

This copies the implementation of ScreenAsh::IsWindowUnderCursor() and
ScreenAsh::GetWindowAtScreenPoint() to ScreenMus; the rest can't be
consolidated because of usage of the display manager, which is mostly
unimplemented on mus+ash.

BUG= 671408 

Review-Url: https://codereview.chromium.org/2726603003
Cr-Commit-Position: refs/heads/master@{#454113}

[modify] https://crrev.com/860df320f00a381f2a743d14a7fc095130428255/ash/mus/BUILD.gn
[modify] https://crrev.com/860df320f00a381f2a743d14a7fc095130428255/ash/mus/screen_mus.cc
[modify] https://crrev.com/860df320f00a381f2a743d14a7fc095130428255/ash/mus/screen_mus.h
[add] https://crrev.com/860df320f00a381f2a743d14a7fc095130428255/ash/mus/screen_mus_unittest.cc

Comment 4 by e...@chromium.org, Mar 2 2017

Status: Fixed (was: Assigned)

Comment 5 by e...@chromium.org, Mar 10 2017

Cc: e...@chromium.org
 Issue 602727  has been merged into this issue.

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment