resources.pak sizes regressions are only tracked on Mac (and not separately: they're bunched together with Google Chrome.app) |
||||
Issue descriptionChrome Version : 56.0.2914.3 It looks like Issue 670734 is a 1MB+ regression in the size of resources.pak, but it was only picked up while monitoring Google\ Chrome.app on Mac: "All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=670734" There's a sizes plot for resources.pak on Linux which also shows the regression, but it's not monitored, and I can't link it do the bug: https://chromeperf.appspot.com/report?sid=65d381ee52ca3e4a5a4ab2eb213dc7d0cf561050695ee068024828fc01ae62e9 There didn't seem to be a resources.pak monitor for and Windows sizes bots when I was browsing through the plots. Can we add resources.pak on Linux to the set of things we monitor for regressions? That would make it easier to diagnose these in future. See also Issue 608067 "Ensure sizes test is measuring the right things on Linux" (Windows: Issue 608065 , Mac: Issue 608063 ) I don't know if we want a platform-specific monitor as well, e.g. for Windows (grt?).
,
Dec 7 2016
Thanks, I added resources.pak on Linux to the monitoring. Assigning to grt to weigh in on Windows.
,
Dec 8 2016
We will get an alert if mini_installer.exe grows (right?). This is good, but it doesn't give us the reason for the growth. Since resources.pak is the third largest file in the archive, I think it makes sense to monitor it on Windows as well. Thanks for checking.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b4a49c9c1f421ccede34b1e0bdc1b0b21610ad1a commit b4a49c9c1f421ccede34b1e0bdc1b0b21610ad1a Author: Annie Sullivan <sullivan@chromium.org> Date: Thu Dec 08 22:27:58 2016 Add resources.pak to Windows sizes test. BUG= 671403 Change-Id: I05f36063746a97fe612e7ca7b4a5bc5e1bd1d6ce Reviewed-on: https://chromium-review.googlesource.com/417995 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> [modify] https://crrev.com/b4a49c9c1f421ccede34b1e0bdc1b0b21610ad1a/scripts/slave/chromium/sizes.py
,
Dec 9 2016
resources.pak chart added on Windows and monitoring turned on: https://chromeperf.appspot.com/report?sid=337ea5fda2e5888e66584d8dfe33a5e5d8f1ced2630e93a19b53b40422f3adc3 |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Dec 5 2016