New issue
Advanced search Search tips

Issue 671401 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 620172
issue 622847
issue 627246



Sign in to add a comment

Devise forwarding mechanism for view/input events down to native

Project Member Reported by jinsuk...@chromium.org, Dec 5 2016

Issue description

ViewAndroidDelegate is meant to be used by ViewAndroid only. We need a separate mechanism for content/embedders to forward Java events such as view/input down to native. This involves a new interface (EventHandler? the right name TBD), ViewAndroid tree, and another interface (ViewClient name TBD) for dispatching calls to native side need to work in collaboration to achieve this. Many refactoring work items depend on the mechanism. I'm filing this bug to clarify the dependencies of them.

Work is in progress here https://codereview.chromium.org/2502763003/


 
Blocking: 620172
Blocking: -664339
Blocking: 622847
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/603de249d822522b152b29184be793550695f2c8

commit 603de249d822522b152b29184be793550695f2c8
Author: jinsukkim <jinsukkim@chromium.org>
Date: Tue Dec 20 00:35:12 2016

Introduce ViewRoot forwarding input/view events to native

This CL introduces a new interface ViewRoot to forward Java
view/input events down to native, replacing the flow through
ContentViewCore.

ViewRoot, ViewAndroid, and ViewClient are put together to adopt
the pattern "chain of responsibility" dispatching the events to
the classes implementing |ViewClient| along the view hierarchy, and
conditionally stopping the processing when required.

Embedders can obtain the interface from WindowAndroid
whose native part is the root of the ViewAndroid hierarchy.
WebView is an exception where all activities share
the WA instance, hence cannot tell which path in the hierarchy
to dispatch the event to. For this reason WebView gets ViewRoot
from the top ViewAndroid (the one right below WA) instead.

|OnPhysicalBackingSizedChanged| is used for an example.

BUG= 671401 

Review-Url: https://codereview.chromium.org/2502763003
Cr-Commit-Position: refs/heads/master@{#439636}

[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/android_webview/native/aw_contents.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/android_webview/native/aw_contents.h
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/blimp/client/core/contents/blimp_contents_view_impl_android.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/browser/android/content_view_core_impl.h
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/BUILD.gn
[add] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/java/src/org/chromium/ui/base/ViewRoot.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/view_android.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/view_android.h
[add] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/view_client.cc
[add] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/view_client.h
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/window_android.cc
[modify] https://crrev.com/603de249d822522b152b29184be793550695f2c8/ui/android/window_android.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66a531490d960df0f12bd6dbb3e1957a04b1516e

commit 66a531490d960df0f12bd6dbb3e1957a04b1516e
Author: jinsukkim <jinsukkim@chromium.org>
Date: Wed Jan 11 01:17:32 2017

Revert "Introduce ViewRoot forwarding input/view events to native"

This is to fix the reported bug before branching. Will reintroduce
this together with what's being handled in https://crrev.com/2595263002.

This reverts commit 603de249d822522b152b29184be793550695f2c8.

BUG=671967,  671401 
TBR=boliu@chromium.org, tedchoc@chromium.org, dtrainor@chromium.org, bshe@chromium.org

Review-Url: https://codereview.chromium.org/2626723003
Cr-Commit-Position: refs/heads/master@{#442752}

[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/android_webview/native/aw_contents.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/android_webview/native/aw_contents.h
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/blimp/client/core/contents/blimp_contents_view_impl_android.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/browser/android/content_view_core_impl.h
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/BUILD.gn
[delete] https://crrev.com/2681632086283869668714416090a3739ff0e879/ui/android/java/src/org/chromium/ui/base/ViewRoot.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/view_android.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/view_android.h
[delete] https://crrev.com/2681632086283869668714416090a3739ff0e879/ui/android/view_client.cc
[delete] https://crrev.com/2681632086283869668714416090a3739ff0e879/ui/android/view_client.h
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/window_android.cc
[modify] https://crrev.com/66a531490d960df0f12bd6dbb3e1957a04b1516e/ui/android/window_android.h

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3d353091d8189530b26c905d6fb688b333fc819

commit a3d353091d8189530b26c905d6fb688b333fc819
Author: jinsukkim <jinsukkim@chromium.org>
Date: Wed Feb 08 01:24:22 2017

ViewRoot class for event forwarding on Android

This CL introduces a new interface ViewRoot to forward Java
view/input events down to native with a view to replacing the flow
through ContentViewCore eventually.

In native side, ViewRoot is a subclass of ViewAndroid. It acts as
the root of a ViewAndroid tree, and receives touch/view events
from embedders. It has a reference to WindowAndroid, and partially
takes over the role it played as the tree root.

ViewRoot is mapped 1:1 to WindowAndroid and shared across all the
contents. WebView is an exception where all activities share the WA
instance.

ViewRoot, ViewAndroid, and ViewClient are put together to adopt
the pattern "chain of responsibility" dispatching the events to
the classes implementing |ViewClient| along the view hierarchy,
and conditionally stopping the processing when required.

ViewRoot is not in use yet. In the follow-up patches it will replace
WindowAndroid. This CL constructs ViewAndroid layout/bound that
mirrors that of Android view in preparation for the upcoming changes.

BUG= 671401 

Review-Url: https://codereview.chromium.org/2645353004
Cr-Commit-Position: refs/heads/master@{#448833}

[modify] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/BUILD.gn
[add] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/java/src/org/chromium/ui/base/ViewRoot.java
[modify] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_android.cc
[modify] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_android.h
[add] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_android_unittest.cc
[add] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_client.cc
[add] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_client.h
[add] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_root.cc
[add] https://crrev.com/a3d353091d8189530b26c905d6fb688b333fc819/ui/android/view_root.h

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d9be7fe7e02868cce6ce9794f973e4a3279cd1

commit 51d9be7fe7e02868cce6ce9794f973e4a3279cd1
Author: jinsukkim <jinsukkim@chromium.org>
Date: Wed Feb 22 22:35:14 2017

Revert "ViewRoot class for event forwarding on Android"

Will take other approach based on per-content EventHandler
for now.

This reverts commit a3d353091d8189530b26c905d6fb688b333fc819.

BUG= 671401 

Review-Url: https://codereview.chromium.org/2702413004
Cr-Commit-Position: refs/heads/master@{#452239}

[modify] https://crrev.com/51d9be7fe7e02868cce6ce9794f973e4a3279cd1/ui/android/BUILD.gn
[delete] https://crrev.com/ad5c9b9b07e5b387c497d351c681d958e47c2b8f/ui/android/java/src/org/chromium/ui/base/ViewRoot.java
[modify] https://crrev.com/51d9be7fe7e02868cce6ce9794f973e4a3279cd1/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/51d9be7fe7e02868cce6ce9794f973e4a3279cd1/ui/android/view_android.cc
[modify] https://crrev.com/51d9be7fe7e02868cce6ce9794f973e4a3279cd1/ui/android/view_android.h
[delete] https://crrev.com/ad5c9b9b07e5b387c497d351c681d958e47c2b8f/ui/android/view_android_unittest.cc
[delete] https://crrev.com/ad5c9b9b07e5b387c497d351c681d958e47c2b8f/ui/android/view_client.cc
[delete] https://crrev.com/ad5c9b9b07e5b387c497d351c681d958e47c2b8f/ui/android/view_client.h
[delete] https://crrev.com/ad5c9b9b07e5b387c497d351c681d958e47c2b8f/ui/android/view_root.cc
[delete] https://crrev.com/ad5c9b9b07e5b387c497d351c681d958e47c2b8f/ui/android/view_root.h

Labels: OS-Android
Status: Fixed (was: Assigned)
Marking it closed as the basic mechanism is now in place.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93bb5a29073d2cb41b20d3cc6cf59459a3906043

commit 93bb5a29073d2cb41b20d3cc6cf59459a3906043
Author: jinsukkim <jinsukkim@chromium.org>
Date: Wed Mar 15 06:50:57 2017

Add display::GetDisplayNearestView

Add a method that gets the display with a given gfx::NativeView.
The present API |display::GetDisplayNearestWindow| was also updated
to accept gfx::NativeWindow to match its signature.

BUG= 671401 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=benwells@chromium.org,sky@chromium.org,boliu@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org

Review-Url: https://codereview.chromium.org/2688413007
Cr-Commit-Position: refs/heads/master@{#457016}

[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/chromeos/display/output_protection_delegate.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/site_per_process_interactive_browsertest.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/views/chrome_views_delegate.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/views/validation_message_bubble_view.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/chromecast/graphics/cast_screen.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/components/constrained_window/constrained_window_views.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/extensions/shell/browser/shell_screen.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/headless/lib/browser/headless_screen.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/headless/lib/browser/headless_screen.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/android/display_android_manager.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/android/display_android_manager.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/android/dummy_screen_android.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/aura/test/test_screen.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/base/layout.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/BUILD.gn
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/ios/screen_ios.mm
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/screen.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/screen.h
[add] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/screen_android.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/screen_aura.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/screen_base.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/screen_base.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/test/test_screen.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/test/test_screen.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/win/screen_win.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/display/win/screen_win.h
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/93bb5a29073d2cb41b20d3cc6cf59459a3906043/ui/views/mus/screen_mus.h

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b

commit a0c89e94b3310fa12b58db00eaca0e66c2f98c7b
Author: tzik <tzik@chromium.org>
Date: Wed Mar 15 07:43:51 2017

Revert of Add display::GetDisplayNearestView (patchset #17 id:790001 of https://codereview.chromium.org/2688413007/ )

Reason for revert:
This CL causes a compile failure on a Mac bot:
https://build.chromium.org/p/chromium/builders/Mac/builds/24801

[38396/49613] CXX obj/extensions/browser/browser_tests/system_display_apitest.o
FAILED: obj/extensions/browser/browser_tests/system_display_apitest.o
(snip)
../../extensions/browser/api/system_display/system_display_apitest.cc:58:37: error: non-virtual member function marked 'override' hides virtual member function
      gfx::NativeView window) const override {
                                    ^
../../ui/display/screen.h:61:19: note: hidden overloaded virtual function 'display::Screen::GetDisplayNearestWindow' declared here: type mismatch at 1st parameter ('gfx::NativeWindow' (aka 'NSWindow *') vs 'gfx::NativeView' (aka 'NSView *'))
  virtual Display GetDisplayNearestWindow(gfx::NativeWindow window) const = 0;
                  ^
../../extensions/browser/api/system_display/system_display_apitest.cc:200:61: error: allocating an object of abstract class type 'extensions::MockScreen'
      : provider_(new MockDisplayInfoProvider), screen_(new MockScreen) {}
                                                            ^
../../ui/display/screen.h:61:19: note: unimplemented pure virtual method 'GetDisplayNearestWindow' in 'MockScreen'
  virtual Display GetDisplayNearestWindow(gfx::NativeWindow window) const = 0;
                  ^
2 errors generated.

Original issue's description:
> Add display::GetDisplayNearestView
>
> Add a method that gets the display with a given gfx::NativeView.
> The present API |display::GetDisplayNearestWindow| was also updated
> to accept gfx::NativeWindow to match its signature.
>
> BUG= 671401 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> TBR=benwells@chromium.org,sky@chromium.org,boliu@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org
>
> Review-Url: https://codereview.chromium.org/2688413007
> Cr-Commit-Position: refs/heads/master@{#457016}
> Committed: https://chromium.googlesource.com/chromium/src/+/93bb5a29073d2cb41b20d3cc6cf59459a3906043

TBR=oshima@chromium.org,boliu@chromium.org,tapted@chromium.org,benwells@chromium.org,sky@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org,jinsukkim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671401 

Review-Url: https://codereview.chromium.org/2747143005
Cr-Commit-Position: refs/heads/master@{#457025}

[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/chromeos/display/output_protection_delegate.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/site_per_process_interactive_browsertest.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/views/chrome_views_delegate.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/views/validation_message_bubble_view.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/chromecast/graphics/cast_screen.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/components/constrained_window/constrained_window_views.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/extensions/shell/browser/shell_screen.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/headless/lib/browser/headless_screen.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/headless/lib/browser/headless_screen.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/android/display_android_manager.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/android/display_android_manager.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/android/dummy_screen_android.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/aura/test/test_screen.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/base/layout.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/BUILD.gn
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/ios/screen_ios.mm
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/screen.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/screen.h
[delete] https://crrev.com/8d9c69e2ce36013e57b553ce6ebdce48dcc2e522/ui/display/screen_android.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/screen_aura.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/screen_base.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/screen_base.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/test/test_screen.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/test/test_screen.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/win/screen_win.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/display/win/screen_win.h
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b/ui/views/mus/screen_mus.h

Sign in to add a comment