New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671400 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Record Device EXTRA when firing a browser intent from the Physical Web

Project Member Reported by cco3@chromium.org, Dec 5 2016

Issue description

This will let the consuming browser know whether there is a device that corresponds to the URL.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06617f6e14805e099200670ea964025a66f316b6

commit 06617f6e14805e099200670ea964025a66f316b6
Author: cco3 <cco3@chromium.org>
Date: Wed Dec 07 01:36:54 2016

Don't cache invalid serialized Physical Web URLs

Currently, when the UrlManager starts, it deserializes our stored
UrlInfos and attempts to gracefully fail if one cannot be deserialized.
However, the URL the info corresponds to may be contained in some still
existent cache.  This change makes sure that only URLs that are
properly deserialized are stored.

BUG= 671400 

Review-Url: https://codereview.chromium.org/2550293003
Cr-Commit-Position: refs/heads/master@{#436825}

[modify] https://crrev.com/06617f6e14805e099200670ea964025a66f316b6/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/06617f6e14805e099200670ea964025a66f316b6/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05eaec60267085699bc11943ff9c6a87be3f6039

commit 05eaec60267085699bc11943ff9c6a87be3f6039
Author: cco3 <cco3@chromium.org>
Date: Wed Dec 07 01:38:32 2016

Refactor Nearby Message listener

Instead of putting the Nearby Message listener directly in the
IntentService, we place it in the PhysicalWebBleClient so that we can
override it with other versions of the listener.

BUG= 671400 

Review-Url: https://codereview.chromium.org/2552143002
Cr-Commit-Position: refs/heads/master@{#436826}

[modify] https://crrev.com/05eaec60267085699bc11943ff9c6a87be3f6039/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyMessageIntentService.java
[modify] https://crrev.com/05eaec60267085699bc11943ff9c6a87be3f6039/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/071c8d5f611a0e60c3521feecbdf868a2361fdd4

commit 071c8d5f611a0e60c3521feecbdf868a2361fdd4
Author: cco3 <cco3@chromium.org>
Date: Thu Dec 08 19:05:36 2016

Include BT addresses in Intents from Physical Web

This change uses BluetoothDevice.EXTRA_DEVICE to include the bluetooth
address of a Physical Web device in the intent sent to the browser.
This may be used by the browser to enable more seamless connections to
BT devices.

BUG= 671400 

Review-Url: https://codereview.chromium.org/2548353004
Cr-Commit-Position: refs/heads/master@{#437300}

[modify] https://crrev.com/071c8d5f611a0e60c3521feecbdf868a2361fdd4/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[modify] https://crrev.com/071c8d5f611a0e60c3521feecbdf868a2361fdd4/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9a6aa2f4a27cba56ecd5683fcbbfa561cc7b5435

commit 9a6aa2f4a27cba56ecd5683fcbbfa561cc7b5435
Author: Conley Owens <cco3@google.com>
Date: Wed Dec 07 02:01:02 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9a6aa2f4a27cba56ecd5683fcbbfa561cc7b5435

commit 9a6aa2f4a27cba56ecd5683fcbbfa561cc7b5435
Author: Conley Owens <cco3@google.com>
Date: Wed Dec 07 02:01:02 2016

Comment 7 by cco3@chromium.org, Dec 10 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment