New issue
Advanced search Search tips

Issue 671399 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

[Media Router] Add a Hide in Menu/Keep in Toolbar option for component action

Project Member Reported by mfo...@chromium.org, Dec 5 2016

Issue description

Extension browser actions have a Hide in Chrome menu/Keep in toolbar toggle for moving between the toolbar and overflow.  This tracks the work to implement this toggle, at least on Mac where drag and drop isn't supported.

 
Status: Assigned (was: Untriaged)
Cc: taku...@chromium.org
 Issue 635703  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e061d2691156d61913a34463e2dfdec172e324b

commit 1e061d2691156d61913a34463e2dfdec172e324b
Author: takumif <takumif@chromium.org>
Date: Fri Mar 03 18:47:03 2017

[Media Router] Add "Hide in menu/Show in toolbar" option to Cast toolbar icon

This CL adds a context menu option of "Hide in menu/Show in toolbar" to the
Cast/Media Router toolbar action to match the functionality of the context menus
for extension actions. This menu option will be disabled when the action is in
the ephemeral state (i.e. the "Always show icon" option is unchecked, and the
icon only shows when Cast is in use), since the position of the icon would not
persist in those cases.

BUG= 671399 

Review-Url: https://codereview.chromium.org/2721953002
Cr-Commit-Position: refs/heads/master@{#454634}

[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/browser/ui/toolbar/media_router_contextual_menu.h
[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/1e061d2691156d61913a34463e2dfdec172e324b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment