New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671397 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 671394



Sign in to add a comment

services/ui/gpu/gpu_main.cc shouldn't depend on MessagePumpForGpu

Project Member Reported by stanisc@chromium.org, Dec 5 2016

Issue description

On Windows 8 and above Chrome GPU process creates a hidden window which is used as a native surface for D3D rendering. Plus there is another hidden window which is created as a parent the surface window. 
These windows used to be created on the main GPU process thread which caused some stability issues because the main thread is performance bottleneck.

We managed to move these windows into a separate thread and switched the main GPU thread message pump to default non-UI type message pump.

See the following changes:
https://codereview.chromium.org/2208153002
https://codereview.chromium.org/2394693002
https://codereview.chromium.org/2432013004

Please remove dependency on MessagePumpForGpu from services/ui/gpu/gpu_main.cc
This is the only remaining code that prevents us from deleting MessagePumpForGpu.
 
Blocking: 671394
Components: Internals>MUS
Labels: Proj-Mustash-Mus-GPU
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e14f3675dcbf7d72739bfdb1517ff2c5d3dd48c

commit 5e14f3675dcbf7d72739bfdb1517ff2c5d3dd48c
Author: sadrul <sadrul@chromium.org>
Date: Sat Dec 10 04:46:47 2016

mus: Remove use of gpu message-pump.

The gpu message-pump is no longer ncessary. It is not used in
chrome-gpu either.

BUG= 671397 

Review-Url: https://codereview.chromium.org/2560303002
Cr-Commit-Position: refs/heads/master@{#437754}

[modify] https://crrev.com/5e14f3675dcbf7d72739bfdb1517ff2c5d3dd48c/services/ui/gpu/gpu_main.cc

Comment 4 by sadrul@chromium.org, Jan 21 2017

Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment