New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671370 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 643784
issue 682806



Sign in to add a comment

Enable cardboard support on non-daydream devices

Project Member Reported by bshe@chromium.org, Dec 5 2016

Issue description

Currently, VrCore doesn't exist on non-daydream phone. So we disabled all VR support on these devices.
We have VrCore version checker. So theoretically, we could try to enable cardboard support now and once VrCore ready, it should work automatically for Cardboard. 
 
Labels: Proj-VR-Daydream

Comment 2 by bshe@chromium.org, Dec 5 2016

Blocking: 643784
Cc: bajones@chromium.org
 Issue 643784  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22648aca08ffd0812837e124fe4074b4572ed5e

commit a22648aca08ffd0812837e124fe4074b4572ed5e
Author: bshe <bshe@chromium.org>
Date: Mon Dec 12 23:55:05 2016

Enable cardboard support for non-Daydream devices

If VrCore exists on non-Daydream devices, WebVR Cardboard support should be enabled.

BUG= 671370 

Review-Url: https://codereview.chromium.org/2556093002
Cr-Commit-Position: refs/heads/master@{#437962}

[modify] https://crrev.com/a22648aca08ffd0812837e124fe4074b4572ed5e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 5 by bshe@chromium.org, Dec 13 2016

Labels: -M-57 Merge-Request-56 M-56
According to discussion offline, we want to try to merge this back to M56.

Comment 6 by dimu@chromium.org, Dec 13 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)

Comment 7 by bshe@chromium.org, Dec 14 2016

Labels: -M-56 -Hotlist-Merge-Approved -Merge-Approved-56 M-57
Status: Fixed (was: Assigned)
Move it back to M57 WITHOUT merge.
It depends on VrCore which is not available on these devices yet. We probably wont have 
enough time to do a full test pass for this. So move it back to M57. Sorry for the noise.
Labels: Proj-VR-Cardboard
Blocking: 682806

Sign in to add a comment