New issue
Advanced search Search tips

Issue 671363 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 664641
issue 673866
issue 674574
issue 674575

Blocking:
issue 674757



Sign in to add a comment

Remove NativeWidgetMus and related classes

Project Member Reported by sky@chromium.org, Dec 5 2016

Issue description

As part of this PointerWatcherEventRouter2 should be renamed to PointerWatcherEventRouter.
 

Comment 1 by sky@chromium.org, Dec 13 2016

Blockedon: 673866

Comment 2 by sky@chromium.org, Dec 13 2016

Blockedon: 664641

Comment 3 by sky@chromium.org, Dec 15 2016

Blockedon: 674574

Comment 4 by sky@chromium.org, Dec 15 2016

Blockedon: 674575

Comment 5 by sadrul@chromium.org, Dec 15 2016

Blockedon: 672913

Comment 6 by sky@chromium.org, Dec 15 2016

Blockedon: -672913

Comment 7 by sky@chromium.org, Dec 15 2016

Blocking: 674757

Comment 8 by sky@chromium.org, Jan 4 2017

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/600b41c186e7ab224a8b356dd09226dd7edd7e3d

commit 600b41c186e7ab224a8b356dd09226dd7edd7e3d
Author: sky <sky@chromium.org>
Date: Wed Jan 04 02:20:58 2017

Removes code using mus client lib

It's no longer used. There is a more cleanup to be done around
renaming files. I'll do that after this.

This also removes what was views_mus_unittests and renames what was views_aura_mus_unittests to views_mus_unittests.

BUG= 671363 
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2611773002
Cr-Commit-Position: refs/heads/master@{#441293}

[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ash/mus/window_manager_application.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/services/navigation/view_impl.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/accessible_pane_view_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/controls/button/custom_button_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/BUILD.gn
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/clipboard_unittest.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/drag_drop_client_mus.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/drag_drop_client_mus.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/drop_target_mus.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/drop_target_mus.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/input_method_mus.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/input_method_mus.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/input_method_mus_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/interactive_ui_tests_mus.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/native_widget_mus.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/native_widget_mus.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/native_widget_mus_unittest.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/pointer_watcher_event_router.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/pointer_watcher_event_router.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/pointer_watcher_event_router_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/screen_mus_unittest.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/surface_context_factory.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/surface_context_factory.h
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/test_utils.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/text_input_client_impl.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/text_input_client_impl.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/unittests_aura_manifest.json
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/mus/views_aura_mus_test_suite.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/views_mus_test_suite.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/window_manager_connection.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/window_manager_connection.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/window_manager_connection_unittest.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/window_tree_host_mus.cc
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/mus/window_tree_host_mus.h
[delete] https://crrev.com/e89e068d8d527239f9de0d7c8350e338ba0db5c1/ui/views/test/native_widget_factory_mus.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/test/views_test_base.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/test/views_test_base.h
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/test/views_test_helper_aura.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/touchui/touch_selection_controller_impl_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/touchui/touch_selection_menu_runner_views_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/view_unittest_aura.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/widget/native_widget_unittest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d/ui/views/widget/widget_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4477cb3b7262d57996862efcebe612a365706d4

commit a4477cb3b7262d57996862efcebe612a365706d4
Author: sky <sky@chromium.org>
Date: Wed Jan 04 05:04:35 2017

Cleanup after removing views-mus code

PointerWatcherEventRouter2 is now PointerWatcherEventRouter and
aura_mus has been renamed to just mus.

BUG= 671363 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2610063002
Cr-Commit-Position: refs/heads/master@{#441321}

[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ash/autoclick/mus/autoclick_application.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ash/mus/window_manager.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ash/mus/window_manager.h
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/chrome/browser/ui/views/frame/immersive_context_mus.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/BUILD.gn
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/mus_client.cc
[modify] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/mus_client.h
[rename] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/pointer_watcher_event_router.cc
[rename] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/pointer_watcher_event_router.h
[rename] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/pointer_watcher_event_router_unittest.cc
[delete] https://crrev.com/180a8c91cfa09bcdc177722282e13fa64f794334/ui/views/mus/run_all_unittests_aura_mus.cc
[delete] https://crrev.com/180a8c91cfa09bcdc177722282e13fa64f794334/ui/views/mus/views_aura_mus_test_suite.h
[rename] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/views_mus_test_suite.cc
[add] https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4/ui/views/mus/views_mus_test_suite.h

Comment 11 by sky@chromium.org, Jan 4 2017

Status: Fixed (was: Started)

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment