New issue
Advanced search Search tips

Issue 671357 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 662995



Sign in to add a comment

Send promotability notification from ResourceProvider to GLStreamTextureImage

Project Member Reported by liber...@chromium.org, Dec 5 2016

Issue description

ResourceProvider knows if a resource would be promoted to overlay if it were backed by a SurfaceView.  If the resource is marked as liking a hint, then ResourceProvider should notify GLStreamTextureImage via a custom GL command about the promotability of that resource.
 
Blocking: 662995
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6408f27c941a3f90119958301b16f3c7cf2ebced

commit 6408f27c941a3f90119958301b16f3c7cf2ebced
Author: liberato <liberato@chromium.org>
Date: Mon Dec 12 18:52:34 2016

Send overlay promotion hints from to GLStreamTextureImage.

ResourceProvider knows if a resource has requested hints about
overlay promotion.  This CL closes the loop, allowing
ResourceProvider to notify a GLStreamTextureImage that's bound to
the resource's texture about the promotion hint.

This is supported only on Android.  The purpose is to let
AndroidVideoDecodeAccelerator figure out if video frames should be
backed by SurfaceTexture or SurfaceView.

BUG= 671357 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2559523002
Cr-Commit-Position: refs/heads/master@{#437906}

[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/cc/output/overlay_candidate.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/cc/output/overlay_candidate.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/cc/output/overlay_processor.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/cc/output/overlay_strategy_underlay.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/cc/resources/resource_provider.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/cc/resources/resource_provider.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/components/display_compositor/compositor_overlay_candidate_validator_android.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_stream_texture_matrix.txt
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/service/gl_stream_texture_image.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/6408f27c941a3f90119958301b16f3c7cf2ebced/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc

Status: Fixed (was: Started)

Sign in to add a comment