Enable VR Shell build flag in Android release builds |
||||||
Issue descriptionFull functionality of VR shell is currently only enabled when setting the enable_vr_shell=true build flag. We should keep the flag (so it is not enabled on other platforms), but it should be enabled for all channels of Android.
,
Dec 5 2016
,
Dec 7 2016
,
Dec 8 2016
,
Dec 8 2016
Change to enable flag is out https://codereview.chromium.org/2559873002/ (although there might be some refactoring work that could go into that change). Either way I'll hold off even if that is approved until the tests are working, see issue 671373 .
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/597a5430c27891e7d1402ea97c7622a666ce5f6c commit 597a5430c27891e7d1402ea97c7622a666ce5f6c Author: amp <amp@chromium.org> Date: Fri Dec 09 20:27:19 2016 Enable VR shell on Android builds BUG= 671349 Review-Url: https://codereview.chromium.org/2559873002 Cr-Commit-Position: refs/heads/master@{#437622} [modify] https://crrev.com/597a5430c27891e7d1402ea97c7622a666ce5f6c/chrome/common/features.gni [modify] https://crrev.com/597a5430c27891e7d1402ea97c7622a666ce5f6c/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
,
Dec 9 2016
,
Dec 9 2016
,
Dec 9 2016
FYI to note the decision, but we disabled the tests to get the flag enabled now rather than waiting. Issue 671373 will track getting the tests working (and enabled) again. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by amp@chromium.org
, Dec 5 2016