New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671349 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR

Blocking:
issue 641038
issue 655199
issue 671300



Sign in to add a comment

Enable VR Shell build flag in Android release builds

Project Member Reported by amp@chromium.org, Dec 5 2016

Issue description

Full functionality of VR shell is currently only enabled when setting the enable_vr_shell=true build flag.

We should keep the flag (so it is not enabled on other platforms), but it should be enabled for all channels of Android.
 

Comment 1 by amp@chromium.org, Dec 5 2016

Note that this should also adjust any functionality that needs to be hidden until full release of Chrome VR behind the VrShell feature flag https://cs.chromium.org/chromium/src/content/public/common/content_features.cc?rcl=0&l=204

Comment 2 by amp@chromium.org, Dec 5 2016

Blocking: 641038

Comment 3 by amp@chromium.org, Dec 7 2016

Blocking: 671300

Comment 4 by amp@chromium.org, Dec 8 2016

Blockedon: 671373

Comment 5 by amp@chromium.org, Dec 8 2016

Change to enable flag is out https://codereview.chromium.org/2559873002/ (although there might be some refactoring work that could go into that change).

Either way I'll hold off even if that is approved until the tests are working, see  issue 671373 .

Comment 7 by amp@chromium.org, Dec 9 2016

Status: Fixed (was: Started)

Comment 8 by amp@chromium.org, Dec 9 2016

Blockedon: -671373

Comment 9 by amp@chromium.org, Dec 9 2016

FYI to note the decision, but we disabled the tests to get the flag enabled now rather than waiting.   Issue 671373  will track getting the tests working (and enabled) again.

Sign in to add a comment