New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-12
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug

Blocked on:
issue 590095



Sign in to add a comment

iframes don't show when in 3D cs transforms

Reported by amir.co...@emaze.com, Dec 5 2016

Issue description

Chrome Version: 57.0.2937.0 canary (64-bit) on Windows 10
<b>Chrome OS Version: <From about:version: Platform x.x.x.x></b>
<b>Chrome OS Platform: <Make/model of computer running Chrome OS></b>
<b>Network info: <network, encryption type, router model (if known)></b>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
Open link:
http://app.emazestaging.com/@AIZZQR#1
It is supposed to open 2 iframes but they don't open, they do open on 
Chrome version Version 54.0.2840.99 m
Seems to be related to 3D transforms in which the iframes appear in
(2)
(3)

Expected Result:

Actual Result:

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
gpu.html
328 KB View Download

Comment 2 by tkent@chromium.org, Dec 9 2016

Components: Blink>CSS>CSS3D
Labels: -OS-Chrome Needs-Feedback OS-Windows
NextAction: 2016-12-26
I can't reproduce in 57.0.2949.0 canary on Win10 nor 56.0.2924.21 beta.

I'm seeing 2 frames, one with video (that plays when clicked) and another with a social media page that opens when clicked.

Is that what we're supposed to see? If not, please provide a screen shot to help us understand the problem.
Labels: M-57
Hi,

I must say it also does not reproduce for me now. Initially it reproduced for me on version 57.0.2937.0 ,now on version 57.0.2949.0 it is fine, I also rebooted since if that has any relevance.

Regards,
   Amir
Hi,
Happens again here:
Link: http://emaze.me/summer#2
Version 57.0.2956.0 canary (64-bit)
There is an iframe in the middle of the page that is not showing.

It does show as expected on:
Version 55.0.2883.87 m

Thank You
Which iframe? What is the DOM id of it in this example?
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 28 2016

Labels: -Needs-Feedback Needs-Review
Owner: schenney@chromium.org
Thank you for providing more feedback. Adding requester "schenney@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Feedback
NextAction: 2017-01-12
On Windows 10, Version 57.0.2966.1 canary SyzyASan, I see the attached screen for the page in comment #6. There are a couple of console errors related to same-origin rules that might be affecting the results.

I'm not seeing that iframe src anywhere in the DevTools resource listing for the page or the network traffic on reload.

Could you verify the screen shot and also check locally for console errors?
cr671348-screen.PNG
1022 KB View Download
I attached screenshots with devtools showing the iframe exists in the page.
iframe2.JPG was taken on Chrome version  55.0.2883.87
iframe.JPG was taken on canary  Version 57.0.2976.0 canary (64-bit)

You can see in Chrome version  55.0.2883.87, the iframe shows (the image boxes in the middle of the page are from the iframe).
In canary  Version 57.0.2976.0, the iframe is not visible - and that is the problem

iframe.JPG
261 KB View Download
iframe2.JPG
254 KB View Download
The console errors are not nice but I do see how it is related, and they also appear on the Chrome version  55.0.2883.87, and there the iframe shows well

Comment 13 by woxxom@gmail.com, Jan 8 2017

Bisect using snapshots and http://emaze.me/summer#2 from #6:
429040 (good) - 429051 (bad), 56.0.2907.0
https://chromium.googlesource.com/chromium/src/+log/9c860c89..fbebed78?pretty=fuller

Owner: ajuma@chromium.org
https://chromium.googlesource.com/chromium/src/+/5e48a2e0284b930c68e73f44ea15807a9ffab541 is in that bisect range. -> ajuma.

Comment 15 by ajuma@chromium.org, Jan 10 2017

Cc: ajuma@chromium.org
Owner: skyos...@chromium.org
That patch was reverted very shortly thereafter in r429227 (and hasn't yet relanded) so that can't be it. Looking at the regression range, https://chromium.googlesource.com/chromium/src/+/3c364c812da0312a104e976ca5838507efe3488e ("Use intersection observer to control frame throttling") seems like the only iframe-related change, so passing to skyostil.
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 17 2017

Labels: -Needs-Feedback Needs-Review
Thank you for providing more feedback. Adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Blink>CSS>CSS3D Blink>Scheduling
Labels: -Needs-Review
Labels: -M-57 ReleaseBlock-Stable M-56
Status: Assigned (was: Unconfirmed)
Labels: -Pri-3 Pri-1
Labels: OS-Linux OS-Mac
Able to reproduce this issue on Mac 10.12.2, Win-10 and Ubuntu 14.04 using latest canary #57.0.2986.0.

skyostil@ - Could you please have a look into this issue.

Thanks...!!
Labels: -M-56 M-57
We're a few days away from the first stable cut for M56, moving back to M57 since there isn't a fix yet and were only accepting high priority merges (security/crashes).
Labels: Needs-triage-Mobile
Cc: ranjitkan@chromium.org
Labels: OS-Android
With respect to the label added: Needs-triage-Mobile, triaged the issue and below are the observations.

Able to reproduce the issue on Mobile device (Tablet and Handset) with the URL "http://emaze.me/summer#2" provided.

Devices Used:
=============
Device Nexus 7 Tablet
Chrome Version: 57.0.2987.9
Android version: 5.0.2/LRX22G

Device: HTC 4
Chrome Version: 58.0.2993.0
Android version: 6.0.1/MMB29M

Observations on Mobile Device: 
===============================
1) Loaded the URL "http://emaze.me/summer#2"
2) Observe the webpage
3) The iframe was not displayed on both handset and tablet.

P.S: Issue was also seen when option "request desktop site" was also checked
Cc: szager@chromium.org ojan@chromium.org
I dug into this and looks like the problem is that IntersectionObserver (well, really LayoutBox::mapToVisualRectInAncestorSpace) computes bogus intersection rectangles when 3D projections are involved. I took a quick stab at fixing this in two ways:

1. By using mapLocalToAncestor() -- but this doesn't take clips into account so it doesn't really help us.

2. By using clampedBoundsOfProjectedQuad() -- but it also somehow ended up in outer space, not sure why. It's as if it's missing the final camera transform.

I'm tempted to first figure out a way to disable throttling if 3D projections are involved and then see if we can find a way to make everything work. WDYT?
Cc: chrishtr@chromium.org
cc chrishtr@, who knows about mapLocalToAncestor
Is this a dup of  issue 590095 ?
#26: partially -- I think we need to resolve the issue with throttling before fixing mapToVisibleRectInAncestorSpace.
Which issue is the "issue with throttling"?
Ah, sorry for being obscure. In M57 we switched frame throttling to determine visibility using IntersectionObserver. Previously I believe it worked with 3D transforms, but because IObs doesn't this has regressed. I'm proposing to opt 3D transformed frames out of throttling to work around this for now.
I see. But just fixing 590095 would also fix the whole issue, right? It seems
better to do that if we can get it done in time.
That's true. I just wasn't sure how difficult it is going to be :)
Do you have a reduced testcase to help with fixing 590095? I don't think
it will be very hard to fix with a good testcase.
Blockedon: 590095
It's not really reduced, but the one in this bug isn't too bad. It's got three iframes which have perspective transforms, and if you add some logging to IntersectionGeometry you'll see the computed rects are bogus.
Labels: Needs-Feedback
amir.cogan@ : Could you please update the thread as per the above comments # 32 & 34 to  help further.
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
Gentle ping..!
amir.cogan@: Could you please update further with your findings as per the above comments # 32 and 34.
I don't think we need any more details here. We just need to fix the blocking  bug 590095 .

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
Hi,

From my end, I don't have a reduced testcase.
I noticed now on Chrome 56.0.2924.87 it also is not showing the iframe properly.
Regards,
Given this bug is also in M56, perhaps we don't need to block M57 on it?
Labels: -M-57 M-58
Per comment #21 and #42, this bug exists on M56 and fix for blocking  bug 590095  isn't ready yet. So punting to M58. 
Just to update!
Issue is still seen on Mac 10.12.3 with chrome version 58.0.3026.0 
skyostil@ Could you please take a look at this issue

Thanks.
Hi, 
We got lately hundreds of complaints on this issue, We have to direct all users to Firefox and Edge. When will this be fixed? 
Thanks
skyostil@ Friendly ping to get an update on this.

Thanks.
Owner: chrishtr@chromium.org
Status: Fixed (was: Assigned)
Verified that the fix for  issue 590095  fixes this bug. Please comment or open
a new bug if you still have an issue.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
This was merged to M58 here: https://bugs.chromium.org/p/chromium/issues/detail?id=590095#c18

Removing Merge-TBD.

Sign in to add a comment